Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests have timing issues #146

Closed
benjamg opened this issue Feb 19, 2016 · 2 comments
Closed

Tests have timing issues #146

benjamg opened this issue Feb 19, 2016 · 2 comments
Labels
libzmqpp

Comments

@benjamg
Copy link
Member

benjamg commented Feb 19, 2016

As seen in #145 we have timing issues in some of the tests, ideally tests shouldn't be effected by each other like that.
benjamg added a commit to benjamg/zmqpp that referenced this issue May 26, 2017
@benjamg
shift tests onto unique port numbers, hopefully fixes zeromq#175 and z…
9a783d0 
…eromq#146
@benjamg
Copy link
Member Author

benjamg commented Nov 1, 2017

Still have tests trying to use unused ports. However as we can get the connection endpoint from the socket options now we should just move the tests to bind to port 0 so the os provides an unused port and then use the socket option to request the connection setting from the bound socket.

@benjamg
Copy link
Member Author

benjamg commented Nov 3, 2017

hopefully pull request #203 fixes this.

@benjamg benjamg closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libzmqpp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamg