Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Led PWM sample #82383

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Led PWM sample #82383

wants to merge 3 commits into from
+53 −1

Conversation

yishai1999
Copy link
Contributor

Added another cute little part to the sample logic and added two more overlay files

@zephyrbot zephyrbot added area: Samples Samples area: LED Label to identify LED subsystem labels Dec 1, 2024
@yishai1999 yishai1999 mentioned this pull request Dec 1, 2024
Open
kartben
kartben requested changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample.yaml and README.rst need to be updated
I would also consider doing the increase-then-decrease in a single loop to avoid duplicating code

@yishai1999
samples: led: pwm: add decreasing brightness logic
2312312 
Add a decreasing brightness phase to the sample's logic.

Signed-off-by: Yishai Jaffe <[email protected]>
@yishai1999
samples: pwm: Add overlay for nucleo_l4r5zi board
37f56d3 
Add Devicetree overlay for sample drivers/led/pwm and fix the one in
basic/blinky_pwm for nucleo_l4r5zi board to set appropriate to enable
pwdleds and set appropriate timer prescaler.

Signed-off-by: Yishai Jaffe <[email protected]>
@yishai1999
samples: led: pwm: Add overlay for stm32f4_disco board
9650b5c 
Add Devicetree overlay for sample drivers/led/pwm for stm32f4_disco
board board to disable gpio leds node.

Signed-off-by: Yishai Jaffe <[email protected]>
@yishai1999
Copy link
Contributor Author

sample.yaml and README.rst need to be updated I would also consider doing the increase-then-decrease in a single loop to avoid duplicating code

I updated the files.
Regarding the single loop - I think it would just make the code less readable. If you have a suggestion for a way to make it look good and in one loop I'm all ears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbilas bbilas Awaiting requested review from bbilas

@Mani-Sadhasivam Mani-Sadhasivam Awaiting requested review from Mani-Sadhasivam

@nashif nashif Awaiting requested review from nashif

@simonguinot simonguinot Awaiting requested review from simonguinot

@kartben kartben Awaiting requested review from kartben

Requested changes must be addressed to merge this pull request.

Assignees

@kartben kartben

Labels
area: LED Label to identify LED subsystem area: Samples Samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yishai1999 @kartben @zephyrbot