samples: fade_led: use all available LEDs #80496
Conversation
yishai1999
force-pushed
the
use_all_pwm_leds
branch
5 times, most recently
from
5ecc8c6 to
0d6f7c4
Compare
|
@kartben Can we merge? |
|
Isn't this sample superseded by |
Not sure but the |
| /* Support up to 4 LEDs*/ | ||
| static const struct pwm_dt_spec pwm_leds[] = {LISTIFY(4, PWM_LED, ())}; |
There was a problem hiding this comment.
Why limit up to 4?
I don't think there's any problem with not placing any limitation here.
There was a problem hiding this comment.
I can raise the number but there needs to be some cap because there needs to be some sort of iteration over the LEDs.
There was a problem hiding this comment.
You can use the DT macros to run for each entry and should be able to construct any length array from that
There was a problem hiding this comment.
Can you give an example? In this case there is no matching compatible string for a pwm LED or something like that so I don't understand how this would be done.
samples/basic/fade_led/src/main.c
Outdated
| ret = pwm_set_pulse_dt(&pwm_leds[i], pulse_widths[i]); | ||
| if (ret) { | ||
| printk("Error %d: failed to set pulse width for LED %d\n", ret, i); | ||
| return 0; |
There was a problem hiding this comment.
It should good to proceed with only what is available here.
Refactored the sample code to use all available PWM LEDs Signed-off-by: Yishai Jaffe <[email protected]>
yishai1999
force-pushed
the
use_all_pwm_leds
branch
from
0d6f7c4 to
ab5fb7e
Compare
@yishai1999 Please can you investigate and eventually fill a bug report ? The |
Ok, I understood the problem and open a PR (#82383). |
Refactored the sample code to use all available PWM LEDs