video: emul: virtual driver for an imager and RX engine #79482

josuah · 2024-10-06T23:21:02Z

This takes inspiration on the other skeleton.c drivers through Zephyr tree:
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/usb/udc/udc_skeleton.c
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/display/display_dummy.c

It acts as a starting point and as a puppet to explain API changes affecting image sensors.

Be used for providing test cases for the entire API, as required for stable APIs.

Utilities are introduced in the process to reduce boilerplate.

Twister command (new with this PR):

west twister --inline-logs --platform native_sim --scenario tests/drivers/video/api/drivers.video.api

Fixes: #73867

josuah · 2024-10-06T23:23:02Z

I note that the frame interval API was merged, this will need to include it.

Video : Add frame interval APIs #72254

josuah · 2024-10-13T13:35:02Z

Aims to cover the most frequent use-cases and facilitate modifications on top
Assume that image sensor drivers are apply modes described by pixelformat+resolution+framerate
For every new sensor, require filling a few tables and let the ready-made functions hook them to the Zephyr video API

josuah · 2024-10-23T09:13:42Z

force-push: unit tests for the emulated drivers: this covers the entire video API except set_signal()

To test: west twister --inline-logs --platform native_sim --scenario tests/drivers/video/api/drivers.video.api

ngphibang · 2024-10-23T14:19:34Z

@josuah : Is the PR ready for review ? Sorry, I asked because I received email notifications of the continuous force-push rather often that make me thinking that this is in development phase. If so, is it better to limit the force push not only to avoid email notifications but also to reduce Zephyr CI kicked-off burden for every push ? If it's not the case, it's OK to do that.

josuah · 2024-10-23T14:25:14Z

@ngphibang you are right, I should work on a separate wip branch and force-push there instead of directly to the PR branch. Thank you for letting me know. Yes this is ready. Twister, check_compliance, and doc build worked locally.

[EDIT: this was thought as being ready at first, and then I thought "let's add unit tests to the same PR", and then "lets' add some more", etc: I should take some time to let things mature and be more reasonable]

josuah · 2024-11-02T21:15:22Z

force-push:

Fix 2 commits being mixed-up
Fix bindings and deviceetree (include i2c-device.yaml or base.yaml)
Use devicetree macros API like in drivers: video: Add endpoint DT helpers #80649
Move video-common.h to video.h as the helpers are usable by the application too.

josuah · 2024-11-03T13:01:13Z

force-push:

Doc build fix
Increment the minor API version as documented. I just found out about this page! This might need an entry in https://github.com/zephyrproject-rtos/zephyr/tree/main/doc/releases for v4.1

PR zephyrproject-rtos#79482 is where this commit would be added Signed-off-by: Josuah Demangeon <[email protected]>

josuah · 2024-11-27T23:33:57Z

In the process of implementing these emulated drivers, I introduced more video API helpers to reduce boilerplate.

If introducing helpers does not make sense in this same PR, I can integrate them back into the emulated drivers to reduce the amount of things this introduces.

ngphibang · 2024-11-28T09:33:54Z

I will try to review this whenever possible, thanks !

pdgendt · 2024-12-01T19:36:58Z

drivers/video/video_emul_imager.c

+	return emul_imager_write_reg(dev, EMUL_IMAGER_REG_CTRL, 0);
+}
+
+static const struct video_driver_api emul_imager_driver_api = {


Please use the DEVICE_API wrapper.

Suggested change

static const struct video_driver_api emul_imager_driver_api = {

static DEVICE_API(video, emul_imager_driver_api) = {

Yes thank you, done.
This will be helpful for checking device types in the video shell based on this PR!

pdgendt · 2024-12-01T19:37:23Z

drivers/video/video_emul_rx.c

+	return 0;
+}
+
+static const struct video_driver_api emul_rx_driver_api = {


Suggested change

static const struct video_driver_api emul_rx_driver_api = {

static DEVICE_API(video, emul_rx_driver_api) = {

Done as well, thank you for the reminder.

loicpoulain · 2024-12-01T20:02:27Z

include/zephyr/drivers/video.h

+ *
+ * @return The frame interval value in microseconds.
+ */
+uint64_t video_frmival_nsec(const struct video_frmival *frmival);


Could this be a simple inline helper?

Yes I agree. Done now.

Introduce a video_get_format_index() utility to help finding a caps entry out of a given format. Introduce several utilities to seek and apply frame intervals. Signed-off-by: Josuah Demangeon <[email protected]>

Add a new implementation of a test pattern generator, with the same architecture as real drivers: split receiver core and I2C-controlled sub-device, with changes of video format in "zephyr,emul-imager" leads to different data produced by "zephyr,emul-rx". Signed-off-by: Josuah Demangeon <[email protected]>

josuah added area: Drivers area: Video Video subsystem labels Oct 6, 2024

zephyrbot requested review from loicpoulain and ngphibang October 6, 2024 23:21

josuah added DNM This PR should not be merged (Do Not Merge) and removed DNM This PR should not be merged (Do Not Merge) labels Oct 6, 2024

josuah marked this pull request as draft October 6, 2024 23:23

josuah force-pushed the pr-video-sensor-skeleton branch 5 times, most recently from eb4a7a4 to cfa3bfb Compare October 13, 2024 13:20

josuah marked this pull request as ready for review October 13, 2024 13:20

zephyrbot added the area: Base OS Base OS Library (lib/os) label Oct 13, 2024

zephyrbot requested review from andyross, dcpleung, nashif and peter-mitsis October 13, 2024 13:20

zephyrbot assigned andyross and nashif Oct 13, 2024

josuah requested review from pillo79 and uLipe October 13, 2024 13:36

josuah force-pushed the pr-video-sensor-skeleton branch 2 times, most recently from 64e0235 to 9a1a450 Compare October 14, 2024 12:02

zephyrbot added platform: STM32 ST Micro STM32 area: Watchdog Watchdog labels Oct 14, 2024

zephyrbot requested review from erwango and FRASTM October 14, 2024 12:03

josuah force-pushed the pr-video-sensor-skeleton branch 2 times, most recently from 12321fb to 9d5cd84 Compare October 23, 2024 09:13

josuah force-pushed the pr-video-sensor-skeleton branch from 9d5cd84 to 5bcba0a Compare October 23, 2024 13:42

josuah removed the DNM This PR should not be merged (Do Not Merge) label Oct 23, 2024

josuah mentioned this pull request Nov 2, 2024

usb: device_next: new USB Video Class (UVC) implementation #76798

Open

josuah force-pushed the pr-video-sensor-skeleton branch from 5bcba0a to 85e458f Compare November 2, 2024 21:12

josuah force-pushed the pr-video-sensor-skeleton branch from 85e458f to eb2d81e Compare November 3, 2024 13:00

josuah added a commit to tinyvision-ai-inc/zephyr that referenced this pull request Nov 4, 2024

drivers: video: add a virtual device pipeline

bb7f70f

PR zephyrproject-rtos#79482 is where this commit would be added Signed-off-by: Josuah Demangeon <[email protected]>

josuah added a commit to tinyvision-ai-inc/zephyr that referenced this pull request Nov 4, 2024

drivers: video: add a virtual device pipeline

c3d5506

PR zephyrproject-rtos#79482 is where this commit would be added Signed-off-by: Josuah Demangeon <[email protected]>

josuah added a commit to tinyvision-ai-inc/zephyr that referenced this pull request Nov 4, 2024

drivers: video: add a virtual device pipeline

545d76a

PR zephyrproject-rtos#79482 is where this commit would be added Signed-off-by: Josuah Demangeon <[email protected]>

josuah added a commit to tinyvision-ai-inc/zephyr that referenced this pull request Nov 12, 2024

drivers: video: add a virtual device pipeline

72b9937

PR zephyrproject-rtos#79482 is where this commit would be added Signed-off-by: Josuah Demangeon <[email protected]>

josuah added a commit to tinyvision-ai-inc/zephyr that referenced this pull request Nov 12, 2024

drivers: video: add a virtual device pipeline

c048319

PR zephyrproject-rtos#79482 is where this commit would be added Signed-off-by: Josuah Demangeon <[email protected]>

josuah added a commit to tinyvision-ai-inc/zephyr that referenced this pull request Nov 17, 2024

drivers: video: add a virtual device pipeline

e326dc0

PR zephyrproject-rtos#79482 is where this commit would be added Signed-off-by: Josuah Demangeon <[email protected]>

josuah added a commit to tinyvision-ai-inc/zephyr that referenced this pull request Nov 21, 2024

drivers: video: add a virtual device pipeline

a5f6339

PR zephyrproject-rtos#79482 is where this commit would be added Signed-off-by: Josuah Demangeon <[email protected]>

josuah mentioned this pull request Nov 27, 2024

Implement video control framework #82158

Open

This was referenced Nov 29, 2024

drivers: video: API enhancement #72959

Open

drivers: video: sensors: add a sensor_skeleton.c to speed-up contribution of simple sensors #73867

Closed

josuah force-pushed the pr-video-sensor-skeleton branch from eb2d81e to 87e71dd Compare December 1, 2024 17:30

pdgendt reviewed Dec 1, 2024

View reviewed changes

loicpoulain reviewed Dec 1, 2024

View reviewed changes

josuah added 2 commits December 1, 2024 22:02

drivers: video: common: Add utilities to seek frmival/caps structures

5afc6ca

Introduce a video_get_format_index() utility to help finding a caps entry out of a given format. Introduce several utilities to seek and apply frame intervals. Signed-off-by: Josuah Demangeon <[email protected]>

josuah force-pushed the pr-video-sensor-skeleton branch from 87e71dd to 6024bb9 Compare December 1, 2024 22:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

video: emul: virtual driver for an imager and RX engine #79482

video: emul: virtual driver for an imager and RX engine #79482

josuah commented Oct 6, 2024 •

edited

Loading

josuah commented Oct 6, 2024

josuah commented Oct 13, 2024

josuah commented Oct 23, 2024 •

edited

Loading

ngphibang commented Oct 23, 2024

josuah commented Oct 23, 2024 •

edited

Loading

josuah commented Nov 2, 2024 •

edited

Loading

josuah commented Nov 3, 2024

josuah commented Nov 27, 2024

ngphibang commented Nov 28, 2024

pdgendt Dec 1, 2024

josuah Dec 1, 2024

pdgendt Dec 1, 2024

josuah Dec 1, 2024

loicpoulain Dec 1, 2024

josuah Dec 1, 2024

	static const struct video_driver_api emul_imager_driver_api = {
	static DEVICE_API(video, emul_imager_driver_api) = {

	static const struct video_driver_api emul_rx_driver_api = {
	static DEVICE_API(video, emul_rx_driver_api) = {

video: emul: virtual driver for an imager and RX engine #79482

Are you sure you want to change the base?

video: emul: virtual driver for an imager and RX engine #79482

Conversation

josuah commented Oct 6, 2024 • edited Loading

josuah commented Oct 6, 2024

josuah commented Oct 13, 2024

josuah commented Oct 23, 2024 • edited Loading

ngphibang commented Oct 23, 2024

josuah commented Oct 23, 2024 • edited Loading

josuah commented Nov 2, 2024 • edited Loading

josuah commented Nov 3, 2024

josuah commented Nov 27, 2024

ngphibang commented Nov 28, 2024

pdgendt Dec 1, 2024

Choose a reason for hiding this comment

josuah Dec 1, 2024

Choose a reason for hiding this comment

pdgendt Dec 1, 2024

Choose a reason for hiding this comment

josuah Dec 1, 2024

Choose a reason for hiding this comment

loicpoulain Dec 1, 2024

Choose a reason for hiding this comment

josuah Dec 1, 2024

Choose a reason for hiding this comment

josuah commented Oct 6, 2024 •

edited

Loading

josuah commented Oct 23, 2024 •

edited

Loading

josuah commented Oct 23, 2024 •

edited

Loading

josuah commented Nov 2, 2024 •

edited

Loading