Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: video: sensors: add a sensor_skeleton.c to speed-up contribution of simple sensors #73867

Closed
josuah opened this issue Jun 6, 2024 · 2 comments · May be fixed by #79482
Closed

drivers: video: sensors: add a sensor_skeleton.c to speed-up contribution of simple sensors #73867

josuah opened this issue Jun 6, 2024 · 2 comments · May be fixed by #79482
Assignees
@josuah
Labels
area: Video Video subsystem Enhancement Changes/Updates/Additions to existing features priority: low Low impact/importance bug

Comments

@josuah
Copy link
Collaborator

josuah commented Jun 6, 2024 •
edited
Loading

Is your enhancement proposal related to a problem? Please describe.
There are more sensor contributions coming to Zephyr, from various location, and not yet guidelines for how to contribute them

Describe the solution you'd like
Having a sensor_skeleton.c would help maintainer communicate how they plan to integrate sensors, and help image sensor driver contributors to get going more quickly by skipping all the boilerplate.

Describe alternatives you've considered

  • Have a video-wide skeleton instead
  • Let things like they are now: no big priority.

Additional context
Other similar "template/skeleton/dummy" drivers:
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/usb/udc/udc_skeleton.c
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/display/display_dummy.c
@josuah josuah added the Enhancement Changes/Updates/Additions to existing features label Jun 6, 2024
This was referenced Jun 6, 2024
Merged
Open
@josuah
Copy link
Collaborator Author

josuah commented Jun 13, 2024

Here is now a list snippets that can be interesting to add:

@henrikbrixandersen henrikbrixandersen added the area: Video Video subsystem label Jun 18, 2024
@josuah josuah self-assigned this Jul 22, 2024
@josuah josuah added the priority: low Low impact/importance bug label Jul 22, 2024
@josuah josuah mentioned this issue Sep 11, 2024
Merged
@josuah josuah mentioned this issue Sep 20, 2024
Merged
@josuah josuah mentioned this issue Oct 6, 2024
Open
josuah added a commit to josuah/zephyr that referenced this issue Oct 13, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
d768815 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to
modify at the same time as API changes.

Introduce a video_get_format_index() to help finding a caps
entry out of a given format.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 13, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
59483ff 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to
modify at the same time as API changes.

Introduce a video_get_format_index() to help finding a caps
entry out of a given format.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 13, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
eb4a7a4 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to
modify at the same time as API changes.

Introduce a video_get_format_index() to help finding a caps
entry out of a given format.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 13, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
cfa3bfb 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to modify
at the same time as API changes.

Introduce a video_get_format_index() utility to help finding a caps
entry out of a given format.

Introduce several utilities to seek and apply frame intervals used
in the skeleton sensor driver.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 13, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
64e0235 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to modify
at the same time as API changes.

Introduce a video_get_format_index() utility to help finding a caps
entry out of a given format.

Introduce several utilities to seek and apply frame intervals used
in the skeleton sensor driver.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 14, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
9a1a450 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to modify
at the same time as API changes.

Introduce a video_get_format_index() utility to help finding a caps
entry out of a given format.

Introduce several utilities to seek and apply frame intervals used
in the skeleton sensor driver.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 14, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
53b34f2 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to modify
at the same time as API changes.

Introduce a video_get_format_index() utility to help finding a caps
entry out of a given format.

Introduce several utilities to seek and apply frame intervals used
in the skeleton sensor driver.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 14, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
2ead072 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to modify
at the same time as API changes.

Introduce a video_get_format_index() utility to help finding a caps
entry out of a given format.

Introduce several utilities to seek and apply frame intervals used
in the skeleton sensor driver.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 15, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
3d5e562 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to modify
at the same time as API changes.

Introduce a video_get_format_index() utility to help finding a caps
entry out of a given format.

Introduce several utilities to seek and apply frame intervals used
in the skeleton sensor driver.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
josuah added a commit to josuah/zephyr that referenced this issue Oct 17, 2024
@josuah
video: sensor_skeleton: starting point for writing new sensors
201c49e 
Provide a default implementation of an image sensor driver to
facilitate writing new drivers, and provide some reference to modify
at the same time as API changes.

Introduce a video_get_format_index() utility to help finding a caps
entry out of a given format.

Introduce several utilities to seek and apply frame intervals used
in the skeleton sensor driver.

Fixes: zephyrproject-rtos#73867
Signed-off-by: Josuah Demangeon <[email protected]>
@josuah
Copy link
Collaborator Author

josuah commented Nov 29, 2024

Closing in favor of #79482 which permits to actually run the skeleton files, making sure the stub works.

@josuah josuah closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josuah josuah

Labels
area: Video Video subsystem Enhancement Changes/Updates/Additions to existing features priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

video: emul: virtual driver for an imager and RX engine josuah/zephyr
2 participants
@henrikbrixandersen @josuah