drivers: i3c: shell: fixups and streamline codebase #78376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved a compilation error where `maxwr`, `maxrd`, and `max_read_turnaround` were incorrectly referenced. The code was updated to correctly access these fields from the `data_speed` structure. Signed-off-by: Pisit Sawangvonganan <[email protected]>
The `<id>` argument was included in `cmd_i3c_ccc_getvendor`, `cmd_i3c_ccc_setvendor`, and `cmd_i3c_ccc_setvendor_bc` but was not processed. Utilized `shell_strtoul` for proper parsing of the `<id>` argument in these functions. Signed-off-by: Pisit Sawangvonganan <[email protected]>
Aligned the `struct shell *` argument name from `shell_ctx` to `sh` for consistency with other drivers' usage of `sh`, and to match the `shell_cmd_handler` argument name. Signed-off-by: Pisit Sawangvonganan <[email protected]>
…intf` Due to the introduction of `shell_fprintf_normal` in PR zephyrproject-rtos#77192, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
XenuIsWatching
approved these changes
Sep 13, 2024
|
We really should get this shell in the CI somehow so I don't make copy and paste mistakes between forks 😅 |
dcpleung
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixups and streamline codebase as follows:
cmd_i3c_ccc_getmxds<id>argument parsingstruct shell *argument name toshshell_fprintf_normalinstead ofshell_fprintf