net: Fix connectivity issues if only UDP or TCP is enabled #776
Conversation
If either UDP or TCP is enabled but not both, then connectivity fails. This was a side effect of commit 3604c39 ("net: udp: Remove NET_UDP_HDR() macro and direct access to net_buf") Jira: ZEP-2380 Signed-off-by: Jukka Rissanen <[email protected]>
There was a problem hiding this comment.
Looks good to me; thanks for the fast response. I can confirm that the issue reported in ZEP-2380 no longer reproduces with this commit, regardless of if UDP is enabled or not.
Going forward, is there some way we can avoid a similar regression in the future? Is there enough CI infrastructure to e.g. run something like the echo client in shippable to verify basic connectivity is maintained?
|
Ah, does this also mean that CONFIG_NET_UDP can be set to n again in samples/net/mqtt_publisher? That was another change in 3604c39 which seemed related to this issue. |
See #752, where I complain that since beginning of the week, I hit 4 issues, cause by 3 recent patches merged. I think there's not enough infrastructure. Shippable just runs sanitycheck. Any networking app simply won't start in qemu unless net_tools daemons are running. Even if we make Shippable run the daemons, those tests will fail when run via sanitycheck in developers' machine. Somebody brave should come up with a solution to this, or propose a completely different way. But there're issues and blockers on each way, so all matter is in impasse ;-). |
Signed-off-by: James Prestwood <[email protected]>
If either UDP or TCP is enabled but not both, then connectivity
fails. This was a side effect of commit 3604c39 ("net: udp:
Remove NET_UDP_HDR() macro and direct access to net_buf")
Jira: ZEP-2380
Signed-off-by: Jukka Rissanen [email protected]