TCP is broken by Zephyr commit 3604c391e #3813
Labels
area: Networking
bug
The issue is a bug, or the PR is fixing a bug
priority: high
High impact/importance bug
Milestone
Reported by Marti Bolivar:
Summary
Commit [3604c39|https://github.com/zephyrproject-rtos/zephyr/commit/3604c391e69d253fb985aa6d072283250b454e6e] ("net: udp: Remove NET_UDP_HDR() macro and direct access to net_buf") breaks TCP functionality in Zephyr. This is true even when UDP is enabled.
Additionally, the changes introduced to get_conn() in subsys/net/ip/connection.c by this commit would appear to cause extra problems in configurations where UDP is disabled. This follows because the call to net_udp_get_hdr() will always return NULL in those configurations. The change made in this commit to samples/net/mqtt_publisher/prj_96b_nitrogen.conf also appears to be incorrect and related, unless the intent is to require UDP for TCP to work as well.
Steps to reproduce:
Setup
Success case
Check out the commit immediately preceeding 3604c39, which is 8476da9, and run the echo_client application targeting QEMU for x86, with the project configuration altered to allow for linux <--> qemu communication as described in prj_qemu_x86.conf.
Observe the echo client application runs successfully.
Detailed logs, with diff shown for how to alter prj_qemu_x86.conf:
Failure case
Check out the commit which introduced the regression, which is 3604c39, making sure to restart the echo-server binary. Run the same test as the success case. Observe TCP verification fails.
Detailed logs, as before:
(Imported from Jira ZEP-2380)
The text was updated successfully, but these errors were encountered: