drivers: sensor: sensor_shell: fix infinite loop when doing sensor get
#72925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should increment `ch.chan_idx` instead of `channel_idx`, otherwise we will be stucked in the loop forever. Signed-off-by: Yong Cong Sin <[email protected]>
ycsin
added
bug
zephyrbot
requested review from
avisconti,
MaureenHelm,
tristan-google,
ubieda and
yperess
teburd
approved these changes
May 17, 2024
|
I believe @ubieda had a patch for this before I pushed that last change, I should have fixed it then, apologies. Thanks for the fix. This is exactly why the shell test is awesome. |
ubieda
approved these changes
May 17, 2024
There was a problem hiding this comment.
It was caught here: #71093 (review).
I'm good with getting this one in and closing mine (#72542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should increment
ch.chan_idxinstead ofchannel_idx, otherwise we will be stucked in the loop forever.