sensors: Add channel specifiers #71093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
avisconti,
MaureenHelm,
tristan-google and
yperess
yperess
previously requested changes
Apr 4, 2024
teburd
force-pushed
the
sensor_api_chan_spec
branch
5 times, most recently
from
1084abb
to
f5bb842
Compare
|
If it's not too much trouble it'd be nice to separate the clang-formatting into a different commit. The new channel struct looks good to me. |
teburd
force-pushed
the
sensor_api_chan_spec
branch
from
f5bb842
to
0ed3ff9
Compare
yeah of course, I can split the commits or drop the unchanged areas that clang-format touched as a whole... seems clang-format version dependent on what it does sometimes |
teburd
force-pushed
the
sensor_api_chan_spec
branch
from
0ed3ff9
to
8274a4d
Compare
teburd
force-pushed
the
sensor_api_chan_spec
branch
6 times, most recently
from
ddbc1cd
to
55f461a
Compare
|
Has turned into a bit of a minor rabbit hole and might not finish before ZDS at this point |
teburd
force-pushed
the
sensor_api_chan_spec
branch
2 times, most recently
from
b7426ac
to
01c66ec
Compare
teburd
force-pushed
the
sensor_api_chan_spec
branch
2 times, most recently
from
fd46712
to
eae752b
Compare
laurenmurphyx64
added a commit
to laurenmurphyx64/zephyr
that referenced
this pull request
May 8, 2024
Updates dht_polling sample to new sensor API. Depends on zephyrproject-rtos#71093 and zephyrproject-rtos#71160. Signed-off-by: Lauren Murphy <[email protected]>
teburd
force-pushed
the
sensor_api_chan_spec
branch
from
06e35e1
to
0e684a0
Compare
|
Update 4: Fix sensor shell build issues |
ubieda
previously approved these changes
May 10, 2024
There was a problem hiding this comment.
I still see the issue with the Sensor Shell command, however, it's easy to fix and there are many PRs depending on this one. I'm approving it since I'm good with merging in and follow-up with subsequent PRs to complement it.
PR with Shell fix: #72542
MaureenHelm
reviewed
May 10, 2024
str4t0m
previously approved these changes
May 13, 2024
teburd
force-pushed
the
sensor_api_chan_spec
branch
2 times, most recently
from
375b0e6
to
8a72f32
Compare
|
Update 5
|
teburd
force-pushed
the
sensor_api_chan_spec
branch
2 times, most recently
from
41a7816
to
b1c0e7e
Compare
Use a structured channel specifier rather than a single enum when specifying channels to read in the new read/decoder API. Replaces usages of a seperate channel and channel_index parameter where previously used with a struct sensor_chan_spec. Signed-off-by: Tom Burdick <[email protected]>
teburd
force-pushed
the
sensor_api_chan_spec
branch
from
b1c0e7e
to
c8df175
Compare
MaureenHelm
approved these changes
May 16, 2024
ubieda
approved these changes
May 17, 2024
laurenmurphyx64
added a commit
to laurenmurphyx64/zephyr
that referenced
this pull request
May 28, 2024
Updates dht_polling sample to new sensor API. Depends on zephyrproject-rtos#71093 and zephyrproject-rtos#71160. Signed-off-by: Lauren Murphy <[email protected]>
laurenmurphyx64
added a commit
to laurenmurphyx64/zephyr
that referenced
this pull request
May 30, 2024
Updates dht_polling sample to new sensor API. Depends on zephyrproject-rtos#71093 and zephyrproject-rtos#71160. Signed-off-by: Lauren Murphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a structured channel specifier rather than a single enum when specifying channels to read in the new read/decoder API.
Implements a slight variation of #63830