-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete set of changes to enable picolibc by default #60124
Closed
keith-packard
wants to merge
3
commits into
zephyrproject-rtos:main
from
keith-packard:picolibc-patches
Closed
Complete set of changes to enable picolibc by default #60124
keith-packard
wants to merge
3
commits into
zephyrproject-rtos:main
from
keith-packard:picolibc-patches
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-packard
requested review from
nashif,
dcpleung,
andyross,
rlubos and
tbursztyka
as code owners
July 6, 2023 23:56
zephyrbot
added
area: Networking
area: C Library
C Standard Library
area: Kernel
area: C++
labels
Jul 6, 2023
zephyrbot
requested review from
alexanderwachter,
ceolin,
cfriedt,
peter-mitsis,
ssharks and
stephanosio
July 6, 2023 23:57
zephyrbot
added
manifest
manifest-sof
DNM
This PR should not be merged (Do Not Merge)
labels
Jul 6, 2023
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
keith-packard
force-pushed
the
picolibc-patches
branch
2 times, most recently
from
July 13, 2023 18:03
5567297
to
cff7627
Compare
keith-packard
force-pushed
the
picolibc-patches
branch
from
July 17, 2023 21:17
cff7627
to
d8c7641
Compare
60 tasks
cfriedt
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - please go ahead and merge zephyrproject-rtos/sof#28
keith-packard
force-pushed
the
picolibc-patches
branch
from
July 18, 2023 22:05
d8c7641
to
75247cd
Compare
keith-packard
force-pushed
the
picolibc-patches
branch
2 times, most recently
from
August 10, 2023 01:40
4fa7d99
to
17a0ef7
Compare
keith-packard
force-pushed
the
picolibc-patches
branch
from
August 22, 2023 00:18
17a0ef7
to
ac002df
Compare
This test fails when icount is disabled, so enable it See 7bdc621 which disabled icount by default for this platform. Signed-off-by: Keith Packard <[email protected]>
This switches the default C library to picolibc for all targets which support it. Signed-off-by: Keith Packard <[email protected]>
With picolibc being the default C library, we need to explicitly include testing against the minimal C library for kernel components. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
picolibc-patches
branch
from
August 22, 2023 00:23
ac002df
to
eb10312
Compare
gmarull
approved these changes
Aug 22, 2023
cfriedt
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: C Library
C Standard Library
area: C++
area: Device Model
area: Kernel
area: Networking
DNM
This PR should not be merged (Do Not Merge)
manifest
manifest-sof
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series incorporates all of the patches necessary to switch to using picolibc by default. All of them are also available as separate PRs, this PR is designed to validate that the full set works as desired.
This is intended to have the changes mentioned in #49922