app: Switch main return type to 'int'

.github/workflows/codestyle.yml

@@ -16,7 +16,7 @@ on: [pull_request]
 
 jobs:
   checkpatch:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     strategy:
       fail-fast: false
@@ -33,7 +33,7 @@ jobs:
       # depth 2 so:
       # ^1. we can show the Subject of the current target branch tip
       # ^2. we reconnect/graft to the later fetch pull/1234/head,
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with: {fetch-depth: 2}
 
       - name: install codespell
@@ -56,7 +56,7 @@ jobs:
   yamllint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: run yamllint
         # Quoting to please all parsers is hard. This indirection helps.

.github/workflows/installer.yml

@@ -17,18 +17,17 @@ on: [push, pull_request, workflow_dispatch]
 
 jobs:
   checktree:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     strategy:
       fail-fast: false
       matrix:  # just a vector in this case
         make_env: [
-          IPC_VERSION=,  # default version
-          IPC_VERSION=IPC4 UNSIGNED_list= SIGNED_list='tgl tgl-h',
+          IPC_VERSION= UNSIGNED_list='imx8' SIGNED_list=,  # default version
         ]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         # From time to time this will catch a git tag and change SOF_VERSION
         with: {fetch-depth: 50, submodules: recursive}
 

.github/workflows/ipc_fuzzer.yml

@@ -8,59 +8,43 @@ name: IPC fuzzing
 # yamllint disable-line rule:truthy
 on: [pull_request, workflow_dispatch]
 
-
-# For the actual fuzzer see tools/oss-fuzz/README.
-# also see
-# https://google.github.io/oss-fuzz/getting-started/continuous-integration/
-#
-# Build and run fuzzer for 5s just to check that it runs properly. If it
-# consistently fails in under 5s you probably did something wrong
-
-# If you came here to quickly copy/paste the invocation of some build
-# script in order to reproduce a failure reported by github then you
-# will be disappointed by the Github Action below: it's magical. For a
-# thorough reproduction you must follow the links above. For a quick,
-# dirty and incomplete reproduction hack you can try the following two
-# lines. Don't do this at home.
-#
-#   OUT=unused_dir  cmake -B oss-fuzz-build/ -S tools/oss-fuzz/
-#   make -j -C oss-fuzz-build sof_ep fuzz_ipc.o
 jobs:
-  ipc-fuzzer-build:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Build Fuzzers
-        uses: google/oss-fuzz/infra/cifuzz/actions/build_fuzzers@master
-        with:
-          oss-fuzz-project-name: 'sound-open-firmware'
-
-      - name: Run Fuzzers
-        uses: google/oss-fuzz/infra/cifuzz/actions/run_fuzzers@master
-        with:
-          oss-fuzz-project-name: 'sound-open-firmware'
-          language: c
-          fuzz-seconds: 5
 
-
-  # TODO, to add IPC4 support fix compilation of:
-  #
-  #    ./scripts/fuzz.sh -t 1 -- -DCONFIG_IPC_MAJOR_4=y
-  #
-  # ... or of some other _IPC4_ -DOVERLAY_CONFIG=
-  #
-  # Then use a simple IPC3/IPC4 matrix like the one in zephyr.yml
-  simple-IPC3-fuzz_sh:
+  simple-IPC-fuzz_sh:
     runs-on: ubuntu-22.04
+    strategy:
+      fail-fast: false
+      matrix:
+        # Keep these names short due to questionable Github UI choices
+        IPC: [IPC3, IPC4]
+
     steps:
       - name: add i386 arch
         run: |
           sudo dpkg --add-architecture i386
           sudo apt-get update
 
-      - name: apt-get install
-        run: sudo apt-get update && sudo apt-get -y install
-          clang llvm libc6-dev-i386 libstdc++-12-dev:i386
-          ninja-build device-tree-compiler python3-pyelftools
+      - name: apt-get install i386 packages
+        run: |
+
+          # We don't know why Github requires us to explicit all these i386
+          # dependencies. On a vanilla Ubuntu 22.04 the last apt-get is
+          # enough.
+          # Also, it does not seem possible to download Github images for
+          # local testing which means trial and error for this requires a
+          # force-push every time: excruciatingly slow!
+          sudo apt-get -y install       \
+            libgcc-s1:i386 libc6-dev:i386 libstdc++6:i386         \
+            libgomp1:i386  libitm1:i386   libatomic1:i386         \
+            libasan8:i386  libubsan1:i386 libquadmath0:i386       \
+
+          sudo apt-get -y install \
+            libc6-dev-i386 libstdc++-12-dev:i386
+
+      - name: apt-get install build tools
+        run:
+          sudo apt-get -y install
+            clang llvm ninja-build device-tree-compiler python3-pyelftools
 
       - uses: actions/checkout@v3
         with:
@@ -78,4 +62,8 @@ jobs:
           cd workspace
           clang --verbose
           set -x
-          sof/scripts/fuzz.sh -o _.log -t 300
+          case '${{ matrix.IPC }}' in
+            IPC3) cmake_arg='-DCONFIG_IPC_MAJOR_3=y' ;;
+            IPC4) cmake_arg='-DCONFIG_IPC_MAJOR_4=y' ;;
+          esac
+          sof/scripts/fuzz.sh -o _.log -t 300 -- "$cmake_arg"

.github/workflows/pull-request.yml

@@ -9,7 +9,7 @@
 # github.com also has a powerful web editor that can be used without
 # committing.
 
-# TODO: finishing scattering this very old workflow to more specific
+# TODO: finish scattering this very old workflow to more specific
 # .yml files
 name: Main Actions
 
@@ -118,7 +118,7 @@ jobs:
 
 
   gcc-build-only:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     strategy:
       fail-fast: false
@@ -127,7 +127,6 @@ jobs:
         # to COMMAS. Don't use a single big group so a single failure
         # does not block all other builds.
         platform: [imx8ulp,
-                   tgl,
                    rn rmb,
                    mt8186 mt8195,
         ]
@@ -154,7 +153,7 @@ jobs:
   # duplication.
 
   qemu-boot-test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     strategy:
       fail-fast: false

.github/workflows/repro-build.yml

@@ -16,10 +16,10 @@ on: [pull_request]
 
 jobs:
   main:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with: {fetch-depth: 5, submodules: recursive}
 
       - name: docker pull

.github/workflows/sparse-zephyr.yml

@@ -15,27 +15,14 @@ jobs:
   # sof/scripts/parse_sparse_output.sh
   warnings-subset:
 
-    # We're sharing binaries with the zephyr-build container so keep
+    # We're sharing the sparse binary with the zephyr-build container so keep
     # this in sync with it.
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     strategy:
       fail-fast: false
       matrix:
-        platforms: [
-          {platform: tgl,
-           real_cc: xtensa-intel_s1000_zephyr-elf/bin/xtensa-intel_s1000_zephyr-elf-gcc},
-          # This is the WRONG compiler for MTL but for now this is the
-          # one and only one expected by the Zephyr build system so it
-          # must be set to this value to sparse MTL.
-          # Sparse needs a REAL_CC but it does not matter which one, it
-          # does not affect sparse results.
-          # As soon as sof/west.yml is updated to a fixed Zephyr version
-          # this will fail with an error message that will show the
-          # exact value that must replace this one.
-          {platform: mtl,
-           real_cc: xtensa-intel_s1000_zephyr-elf/bin/xtensa-intel_s1000_zephyr-elf-gcc},
-        ]
+        platform: [tgl, mtl, lnl]
 
     steps:
       - name: git clone sparse analyzer
@@ -67,22 +54,16 @@ jobs:
       - name: Download docker image && ls /opt/toolchains/
         run: cd workspace && ./sof/zephyr/docker-run.sh ls -l /opt/toolchains/
 
-      # We have to painfully extract REAL_CC from the docker image to
-      # tell the Zephyr build what it... already knows and wants!! Zephyr
-      # commit 3ebb18b8826 explains this sparse problem.
-      #
       # --pristine is important to reproduce _warnings_. It makes no
       # difference for github but it's useful for anyone trying to
       # reproduce and copying the command from the logs.
       - name: analyze zephyr
         working-directory: ./workspace
         run: |
-          ./sof/zephyr/docker-run.sh /bin/sh -c               \
-            'cmake -P ./sof/zephyr/FindZephyr-sdk.cmake > zsdk_location'
-          cat zsdk_location
-          ZSDK=$(cat zsdk_location); _RCC=${{ matrix.platforms.real_cc }}
-          REAL_CC="$ZSDK/$_RCC" ./sof/zephyr/docker-run.sh                          \
-             ./sof/zephyr/docker-build.sh ${{ matrix.platforms.platform }}          \
-             --cmake-args=-DSPARSE=y --pristine 2>&1 | tee _.log
+             ./sof/zephyr/docker-run.sh                          \
+             ./sof/zephyr/docker-build.sh ${{ matrix.platform }}          \
+             --cmake-args=-DZEPHYR_SCA_VARIANT=sparse --cmake-args=-DCONFIG_LOG_USE_VLA=n  \
+             --pristine 2>&1 | tee _.log
+
              printf '\n\n\t\t\t  ---- Messages below are treated as sparse errors --- \n\n\n'
              (set -x; ./sof/scripts/parse_sparse_output.sh ${{ matrix.platforms.platform }} <_.log)

.github/workflows/testbench.yml

@@ -33,7 +33,7 @@ jobs:
     runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with: {fetch-depth: 5}
 
       - name: apt get

.github/workflows/tools.yml

@@ -12,7 +12,7 @@ jobs:
   top-level_default_CMake_target_ALL:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       # The ALSA version in Ubuntu 20.04 is buggy
       # (https://github.com/thesofproject/sof/issues/2543) and likely

.github/workflows/unit-tests.yml

@@ -14,7 +14,7 @@ jobs:
   cmocka_utests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with: {fetch-depth: 2}
 
       - name: build and run all defconfigs