drivers: display: fix zero-buffers-in-SRAM case in DCNANO LCDIF #58879
Conversation
zephyrbot
requested review from
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
EmilioCBen,
iuliana-prodan,
jfischer-no,
manuargue and
yvanderv
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @aedancullen, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
There was a problem hiding this comment.
Hi @aedancullen, thanks for the contribution! The CI pipeline seems to be flagging a compliance issue with your commit message. You need to insure that each line of the commit message body is no more than 75 characters long.
Also, this issue appears to be resolving a bug. The project is currently in a feature freeze state, so we can only merge PRs that explicitly link to a github issue, or make documentation updates.
I've created an issue to highlight this bug, if you add the following text to your commit message body:
Fixes #58908, then the issue should be linked.
|
It's also worth noting that when |
If CONFIG_MCUX_DCNANO_LCDIF_EXTERNAL_FB_MEM is not set and CONFIG_MCUX_DCNANO_LCDIF_FB_NUM is zero, a division by zero occurs. Use the same framebuffer size definition as in the external-framebuffer case to resolve this. Fixes zephyrproject-rtos#58908. Signed-off-by: Aedan Cullen <[email protected]>
aedancullen
force-pushed
the
fix/dcnano-zero-buffers
branch
from
fe5dd25
to
ecaf583
Compare
There was a problem hiding this comment.
Hi @aedancullen!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
If
CONFIG_MCUX_DCNANO_LCDIF_EXTERNAL_FB_MEMis not set andCONFIG_MCUX_DCNANO_LCDIF_FB_NUMis zero, a division by zero occurs. Use the same framebuffer size definition as in the external-framebuffer case to resolve this.