Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCDIF DCNANO Build fails when external memory is disabled and no driver framebuffers are allocated #58908

Closed
danieldegrasse opened this issue Jun 6, 2023 · 0 comments · Fixed by #58879
Closed

LCDIF DCNANO Build fails when external memory is disabled and no driver framebuffers are allocated #58908

danieldegrasse opened this issue Jun 6, 2023 · 0 comments · Fixed by #58879
Assignees
@danieldegrasse
Labels
bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: low Low impact/importance bug

Comments

@danieldegrasse
Copy link
Collaborator

Describe the bug
Building MCUX DCNANO LCDIF driver fails when CONFIG_MCUX_DCNANO_LCDIF_EXTERNAL_FB_MEM=n and CONFIG_MCUX_DCNANO_LCDIF_FB_NUM=0

To Reproduce
Steps to reproduce the behavior:

  1. west build -p always -b mimxrt595_evk_cm33 samples/subsys/display/lvgl/ -DCONFIG_MCUX_DCNANO_LCDIF_EXTERNAL_FB_MEM=n -DCONFIG_MCUX_DCNANO_LCDIF_FB_NUM=0
  2. see error

Expected behavior
Build should succeed.

Additional context
This issue was not caught by CI as the default configuration for the DCNANO LCDIF defaults to external FB memory, as the on chip SRAM is not large enought to store the LCDIF buffers for the default display on the RT595 EVK.
@danieldegrasse danieldegrasse added bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: low Low impact/importance bug labels Jun 6, 2023
aedancullen added a commit to aedancullen/zephyr that referenced this issue Jun 6, 2023
@aedancullen
drivers: display: fix zero-buffers-in-SRAM case in DCNANO LCDIF
ecaf583 
If CONFIG_MCUX_DCNANO_LCDIF_EXTERNAL_FB_MEM is not set and
CONFIG_MCUX_DCNANO_LCDIF_FB_NUM is zero, a division by zero occurs.
Use the same framebuffer size definition as in the external-framebuffer
case to resolve this.

Fixes zephyrproject-rtos#58908.

Signed-off-by: Aedan Cullen <[email protected]>
@danieldegrasse danieldegrasse linked a pull request Jun 13, 2023 that will close this issue
drivers: display: fix zero-buffers-in-SRAM case in DCNANO LCDIF #58879
Merged
nashif pushed a commit that referenced this issue Jun 15, 2023
@aedancullen @nashif
drivers: display: fix zero-buffers-in-SRAM case in DCNANO LCDIF
785d9bd 
If CONFIG_MCUX_DCNANO_LCDIF_EXTERNAL_FB_MEM is not set and
CONFIG_MCUX_DCNANO_LCDIF_FB_NUM is zero, a division by zero occurs.
Use the same framebuffer size definition as in the external-framebuffer
case to resolve this.

Fixes #58908.

Signed-off-by: Aedan Cullen <[email protected]>
hlord2000 pushed a commit to hlord2000/zephyr that referenced this issue Jul 3, 2023
@aedancullen @hlord2000
drivers: display: fix zero-buffers-in-SRAM case in DCNANO LCDIF
b30f5ee 
If CONFIG_MCUX_DCNANO_LCDIF_EXTERNAL_FB_MEM is not set and
CONFIG_MCUX_DCNANO_LCDIF_FB_NUM is zero, a division by zero occurs.
Use the same framebuffer size definition as in the external-framebuffer
case to resolve this.

Fixes zephyrproject-rtos#58908.

Signed-off-by: Aedan Cullen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieldegrasse danieldegrasse

Labels
bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drivers: display: fix zero-buffers-in-SRAM case in DCNANO LCDIF aedancullen/zephyr
1 participant
@danieldegrasse