-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xtensa: Set CONFIG_DCACHE_LINE_SIZE for NXP/Intel boards used in SOF module #57926
xtensa: Set CONFIG_DCACHE_LINE_SIZE for NXP/Intel boards used in SOF module #57926
Conversation
Thanks to PR [1] which introduces support for cache management operations on xtensa architecture NXP SoCs can now use the Zephyr native cache management API. This commit enables some configurations that will allow us to use the native Zephyr cache management API. [1]: zephyrproject-rtos#50136 Signed-off-by: Laurentiu Mihalcea <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for all Intel bits.
I don't understand why we need this definition? We already have defined |
4a015b6
to
931b57a
Compare
Sadly that can't be used in SOF as the size of the data cache line needs to be known at build time as the alignment of some data (e.g: the heap) depends on it. |
Update: added CONFIG_DCACHE_LINE_SIZE for intel_adsp_ace20_lnl. |
931b57a
to
51eb1a1
Compare
This commit sets the DCACHE_LINE_SIZE config for all xtensa-based Intel SoCs for SOF usage. Signed-off-by: Laurentiu Mihalcea <[email protected]>
This commit sets the DCACHE_LINE_SIZE config for all xtensa-based NXP SoCs for SOF usage. Signed-off-by: Laurentiu Mihalcea <[email protected]>
We can still read it from DT at build time. DT_PROP_OR(DT_PATH(cpus, cpu_0), d_cache_line_size, 0); |
Agreed but is there a reason for which this approach is better than the current one? We'd still have to add said property to all the NXP boards and EDIT: Also seems kinda odd to query the property of a CPU you have disabled (i.e: in the case of i.MX93 which uses CPU 1 not CPU 0 which is disabled) |
No description provided.