Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Fix Zephyr SOF support for cAVS 1.8 #29965

Closed
wants to merge 15 commits into from
Closed

[DRAFT] Fix Zephyr SOF support for cAVS 1.8 #29965

wants to merge 15 commits into from

Commits on Nov 11, 2020

  1. modules: Add Sound Open Firmware module 

    Add the Sound Open Firmware project as a Zephyr module under
modules/audio/sof.

Signed-off-by: Andy Ross <[email protected]>
    @lyakh
    Andy Ross authored and lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    c1abd6e View commit details
    Browse the repository at this point in the history

  2. samples/audio: Add Sound Open Firmware 

    Adds the Sound Open Firmware project, built as a Zephyr application,
under samples/subsys/sudio/sof.

Signed-off-by: Liam Girdwood <[email protected]>
    @lrgirdwo @lyakh
    lrgirdwo authored and lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    57df1f3 View commit details
    Browse the repository at this point in the history

  3. rimage: update rimage: add configuration and extended manifest 

    rimage dropped its "-m" parameter and switched over to using "-c"
for a configuration file, including a target name.

Add support for extended manifest for all cAVS versions.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    82a6358 View commit details
    Browse the repository at this point in the history

  4. cavs: restore a missing header 

    soc/xtensa/intel_adsp/common/include/cavs/memory.h wend missing from
the SOF update, restore it.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    c9938d4 View commit details
    Browse the repository at this point in the history

  5. sof: remove superfluous and duplicate code 

    1. SOF doesn't have to be built in .bin format
2. don't include soc.c and soc_mp.c twice in cmake
3. remove an unused mailbox.h header and unused code in adsp.c

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    7f1b03d View commit details
    Browse the repository at this point in the history

  6. sof: enable compilation on unsupported platforms 

    This allows building SOF for unsupported platforms to enable
compilation testing and to simplify porting to new platforms.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    18da5ed View commit details
    Browse the repository at this point in the history

  7. cavs: disable all interrupts when configuring interrupt controllers 

    Some interrupts can be enabled by the ROM, e.g. the timer interrupt.
When then in Zephyr the interrupt controller is enabled, before
individual interrupts are configured, interrupts can arrive and lead
to the spurious interrupt handler being invoked. Fix thid by
disabling all child interrupts when configuring cAVS interrupt
controllers.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    5c6040d View commit details
    Browse the repository at this point in the history

  8. cavs: unify defconfigs for v15, v18, v20 and v25 

    Unify default configurations to support both SMP and UP:

1. make SMP default, although it's currently disabled in prj.conf
2. use CAVS timer by default in both UP and SMP configurations
3. make MP_NUM_CPUS, IPM and IPM_CAVS_IDC depend on SMP

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    c7923e8 View commit details
    Browse the repository at this point in the history

  9. cavs: fix manifest base address 

    On cAVS 1.5, 2.0 and 2.5 platforms the correct manifest address is
0xB0032000.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    b64d8ee View commit details
    Browse the repository at this point in the history

  10. xtensa: disable unused memory power down 

    The current unused memory calculation is broken because it doesn't
take into account the stack area, allocated at the top of HP SRAM.
Until this is fixed disable powering down unused RAM.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    b4ade5a View commit details
    Browse the repository at this point in the history

  11. cavs: fix shim register location on 1.8 and above 

    Shim register location on cAVS 1.5 is different than on 1.8 and up,
fix it.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1bc66cc View commit details
    Browse the repository at this point in the history

  12. xtensa: IPM is only required if SMP is enabled 

    A configuration with CONFIG_MP_NUM_CPUS > 1 and CONFIG_IPM_CAVS_IDC not
defined is valid if COMFIG_SMP is disabled.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1a81fe7 View commit details
    Browse the repository at this point in the history

  13. cavs: (cosmetic) clean up and simplification of intc_cavs.c 

    1. don't use "inline" in .c, let the compiler decide
2. remove superfluous parentheses
3. simplify a function by directly returning the result of a boolean
operation

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    c26eb04 View commit details
    Browse the repository at this point in the history

  14. intel-adsp: disable SMP support in sync with SOF 

    soc/xtensa/intel_adsp/common/include/cavs/cpu.h redefines
PLATFORM_CORE_COUNT and PLATFORM_MASTER_CORE_ID which are already
defined in SOF. Be careful to avoid conflicts. Ideally one of the
two files should be removed.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1522087 View commit details
    Browse the repository at this point in the history

  15. sof: fix logging on cAVS 1.8, 2.0 and 2.5 

    The logging base address, provided by the LOG_BACKEND_RB_MEM_BASE
Kconfig option has been copied from cAVS 1.5, but it's different on
versions 1.8, 2.0 and 2.5. This patch fixes logtool functionality
on those platforms.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
    @lyakh
    lyakh committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    37359f8 View commit details
    Browse the repository at this point in the history