arch: sam3x: update Kconfig options after move to SAM SoC family tree #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the grouping for debugging options appearing in the main "menuconfig" menu. Change-Id: I7ddf3a6f3d025bf82ba63099b30e47a40d7c3187 Signed-off-by: Leandro Pereira <[email protected]>
Signed-off-by: Anas Nashif <[email protected]>
Jira: ZEP-2055 Signed-off-by: David B. Kinder <[email protected]>
This is mostly resulting from the recent change to new integer types. Change-Id: I16aa4ca645c24d682667985de14687a7dc360b2f Signed-off-by: Johan Hedberg <[email protected]>
The switch from C99 integer types to u16_t, etc. caused misalignment in structs and function definitions with multi-line parameter lists. Change-Id: Ic0e33dc199f834ad7772417bca4c0b2d2f779d15 Signed-off-by: Johan Hedberg <[email protected]>
This information should be part of the main BR/EDR context struct, rather than there being a separate member in struct bt_dev. If/when the needed ESCO information grows we can consider having a separate struct, but even then it should be part of the main BR/EDR struct instead of sitting directly in bt_dev. Change-Id: I3edf120606ea6c6974f515bba90de2b25fc6fac6 Signed-off-by: Johan Hedberg <[email protected]>
The switch from C99 integer types to u16_t, etc. caused misalignment in structs and function definitions with multi-line parameter lists. Change-Id: I1448b159ab1afe50ff88b7a6bd1b254c44858d4c Signed-off-by: Carles Cufi <[email protected]>
Remove BT_ prefix from BT_L2CAP_MAX_LE_MPS and BT_L2CAP_MAX_LE_MTU as they are internal to l2cap.c file. Change-id: I6abec0a1f07b8aef49940ab7abeaacbd19947e0b Signed-off-by: Vinayak Chettimada <[email protected]>
L2CAP Tx segmentation used BT_L2CAP_RX_MTU value which is the value used by fixed channel protocols. Decoupling the buffer size provides the opportunity to reduce RAM used per connection. Change-id: Id064f9b2e3f02073402815d09c3ea13a35df2a6c Signed-off-by: Vinayak Chettimada <[email protected]>
The segment allocation function can't fail (it eventually waits with K_FOREVER for a buffer to become available), so there's no point in checking its return value for NULL. Also, the connection state check is because of this particular waiting and not the semaphore waiting (which is done with K_NO_WAIT). Change-Id: I9698760541de810869cffc1c60cf97c5f8f7df8d Signed-off-by: Johan Hedberg <[email protected]>
This function already has an 'i' variable on the top-level, so no need to declare a second one that'd just shadow the original. Change-Id: I5dfa4df2c4793be220a40ac642b19bf440e80220 Signed-off-by: Johan Hedberg <[email protected]>
L2CAP Dynamic Channel feature uses the global connection Tx pool for segmentation either when there is no free buffers in the original application pool or when the original data buffer has no headroom to add L2CAP headers. This eliminates the need for a dedicated fallback pool for Dynamic Channel segmentation. Change-id: Ia5452c814169d17ef261ecef425a8fcf2e7e1e84 Signed-off-by: Vinayak Chettimada <[email protected]>
If the channel is already in use don't attempt to connect it a second time. Change-Id: I87bdaeadbe866b59c1a7975002699d9ef7a90c61 Signed-off-by: Luiz Augusto von Dentz <[email protected]>
Added Bluetooth v4.1 Low Duty Cycle Directed Advertising feature. Change-id: I6ca665e298b343200c65405739f3998bc78b84e7 Signed-off-by: Vinayak Chettimada <[email protected]>
In the Controller's radio hal, explicitly differentiate between Advertisement and Data channel packet configuration. Also, remove nRF5x specific extra overhead in Advertisement PDU structure. Change-id: I942b88a160af78f8900d7e49fb5f36c8aa493b97 Signed-off-by: Vinayak Chettimada <[email protected]>
Rename occurences of bt_hci_ev_* to more widely used bt_hci_evt_* namespace. Change-id: I742fb86f8f835a0f6072638e1e997ad08891d43d Signed-off-by: Vinayak Chettimada <[email protected]>
Fix the attr->handler reference to attr->handle. Change-Id: I4a6ccee7860abf800f51df404979eac18eb26e8e Signed-off-by: Michael Scott <[email protected]>
Rename ll_address_* to ll_addr_*. Also, update ll_addr_get to return reference to stored public or random address. Change-id: I22cb0135d2223f679c4d9321f4724f8b7de0aede Signed-off-by: Vinayak Chettimada <[email protected]>
Several minor changes to clean up I2C Kconfig file - align help text - remove duplicate dependencies - use unified naming for I2C port options - replace outdated references to datasheet in help text - add comments at the end of 'endif' Change-Id: I452083feb29f40909e6e38324ff9d9961fc6bd07 Signed-off-by: Piotr Mienkowski <[email protected]>
The files for the Arduino Due needed to be updated to use the new configuration when the SoC moved from the atmel_sam3 directory to the atmel_sam/sam3x directory. Change-Id: I744a490ffb574cb29e5a4b74484c15ca6dd30617 Origin: Original Jira: ZEP-2067 Signed-off-by: Justin Watson <[email protected]>
The files for the Arduino Due needed to be updated to use the new configuration when the SoC moved from the atmel_sam3 directory to the atmel_sam/sam3x directory. Change-Id: I744a490ffb574cb29e5a4b74484c15ca6dd30617 Origin: Original Jira: ZEP-2067 Signed-off-by: Justin Watson <[email protected]>
|
I messed up. I started with master branch instead of arm. I am going to make a patch out of this and a new branch/PR starting from the arm branch. |
npitre
pushed a commit
to npitre/zephyr
that referenced
this pull request
Oct 31, 2020
The _ldiv5() is an optimized divide-by-5 function that is smaller and
faster than the generic libgcc implementation.
Yet it can be made even smaller and faster with this replacement
implementation based on a reciprocal multiplication plus some tricks.
For example, here's the assembly from the original code on ARM:
_ldiv5:
ldr r3, [r0]
movw ip, zephyrproject-rtos#52429
ldr r1, [r0, zephyrproject-rtos#4]
movt ip, 52428
adds r3, r3, zephyrproject-rtos#2
push {r4, r5, r6, r7, lr}
mov lr, #0
adc r1, r1, lr
adds r2, lr, lr
umull r7, r6, ip, r1
lsr r6, r6, zephyrproject-rtos#2
adc r7, r6, r6
adds r2, r2, r2
adc r7, r7, r7
adds r2, r2, lr
adc r7, r7, r6
subs r3, r3, r2
sbc r7, r1, r7
lsr r2, r3, zephyrproject-rtos#3
orr r2, r2, r7, lsl zephyrproject-rtos#29
umull r2, r1, ip, r2
lsr r2, r1, zephyrproject-rtos#2
lsr r7, r1, zephyrproject-rtos#31
lsl r1, r2, zephyrproject-rtos#3
adds r4, lr, r1
adc r5, r6, r7
adds r2, r1, r1
adds r2, r2, r2
adds r2, r2, r1
subs r2, r3, r2
umull r3, r2, ip, r2
lsr r2, r2, zephyrproject-rtos#2
adds r4, r4, r2
adc r5, r5, #0
strd r4, [r0]
pop {r4, r5, r6, r7, pc}
And here's the resulting assembly with this commit applied:
_ldiv5:
push {r4, r5, r6, r7}
movw r4, zephyrproject-rtos#13107
ldr r6, [r0]
movt r4, 13107
ldr r1, [r0, zephyrproject-rtos#4]
mov r3, #0
umull r6, r7, r6, r4
add r2, r4, r4, lsl zephyrproject-rtos#1
umull r4, r5, r1, r4
adds r1, r6, r2
adc r2, r7, r2
adds ip, r6, r4
adc r1, r7, r5
adds r2, ip, r2
adc r2, r1, r3
adds r2, r4, r2
adc r3, r5, r3
strd r2, [r0]
pop {r4, r5, r6, r7}
bx lr
So we're down to 20 instructions from 36 initially, with only 2 umull
instructions instead of 3, and slightly smaller stack footprint.
Signed-off-by: Nicolas Pitre <[email protected]>
andrewboie
pushed a commit
that referenced
this pull request
Nov 9, 2020
The _ldiv5() is an optimized divide-by-5 function that is smaller and
faster than the generic libgcc implementation.
Yet it can be made even smaller and faster with this replacement
implementation based on a reciprocal multiplication plus some tricks.
For example, here's the assembly from the original code on ARM:
_ldiv5:
ldr r3, [r0]
movw ip, #52429
ldr r1, [r0, #4]
movt ip, 52428
adds r3, r3, #2
push {r4, r5, r6, r7, lr}
mov lr, #0
adc r1, r1, lr
adds r2, lr, lr
umull r7, r6, ip, r1
lsr r6, r6, #2
adc r7, r6, r6
adds r2, r2, r2
adc r7, r7, r7
adds r2, r2, lr
adc r7, r7, r6
subs r3, r3, r2
sbc r7, r1, r7
lsr r2, r3, #3
orr r2, r2, r7, lsl #29
umull r2, r1, ip, r2
lsr r2, r1, #2
lsr r7, r1, #31
lsl r1, r2, #3
adds r4, lr, r1
adc r5, r6, r7
adds r2, r1, r1
adds r2, r2, r2
adds r2, r2, r1
subs r2, r3, r2
umull r3, r2, ip, r2
lsr r2, r2, #2
adds r4, r4, r2
adc r5, r5, #0
strd r4, [r0]
pop {r4, r5, r6, r7, pc}
And here's the resulting assembly with this commit applied:
_ldiv5:
push {r4, r5, r6, r7}
movw r4, #13107
ldr r6, [r0]
movt r4, 13107
ldr r1, [r0, #4]
mov r3, #0
umull r6, r7, r6, r4
add r2, r4, r4, lsl #1
umull r4, r5, r1, r4
adds r1, r6, r2
adc r2, r7, r2
adds ip, r6, r4
adc r1, r7, r5
adds r2, ip, r2
adc r2, r1, r3
adds r2, r4, r2
adc r3, r5, r3
strd r2, [r0]
pop {r4, r5, r6, r7}
bx lr
So we're down to 20 instructions from 36 initially, with only 2 umull
instructions instead of 3, and slightly smaller stack footprint.
Signed-off-by: Nicolas Pitre <[email protected]>
trond-snekvik
added a commit
to trond-snekvik/zephyr
that referenced
this pull request
Jul 23, 2021
…merge_2021_02_22 Merge upstream Zephyr 2021-02-22
NickolasLapp
added a commit
to NickolasLapp/zephyr
that referenced
this pull request
Jan 19, 2023
…ll-in-power-domain-gpio-fixes Nlapp/gen2/pull in power domain gpio fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files for the Arduino Due needed to be updated to use the new
configuration when the SoC moved from the atmel_sam3 directory to
the atmel_sam/sam3x directory.
Change-Id: I744a490ffb574cb29e5a4b74484c15ca6dd30617
Jira: ZEP-2067
Signed-off-by: Justin Watson [email protected]