OpenAMP rsc table sample #16985

arnopo · 2019-06-21T15:52:28Z

This pull request proposes an implementation of the RPMSg protocol based on a resource table.
The resource table can be use to declare resources shared between the main and coprocessor. It is integrated in the co-processor firmware in a specific section. This section can be recognized and parsed by the Linux OS kernel to initialize shared resources such as trace and RPMsg protocol.

Based on this resource table, the objective is to propose a sample that is platform agnostic and that answers to the Linux rpmsg client sample integrated in the Linux kernel distribution.

For time being this pull request only implements the co-processor side, and could be extended in future to also implement the master part.

samples/subsys/ipc/openamp_rsc_table/README.rst

arnopo · 2019-06-24T12:59:38Z

@galak Please, could you take a look to this pull request and associated OpenAMP pull request: zephyrproject-rtos/open-amp#2.
I'm not sure that adding the resource table directly in open-amp module is the right solution, so if you have better suggestion, don't hesitate!

samples/subsys/ipc/openamp_rsc_table/README.rst

dbkinder

doc changes LTGM, thanks!

erwango

First batch of comments

modules/Kconfig.rsc-table

soc/arm/st_stm32/stm32mp1/CMakeLists.txt

samples/subsys/ipc/openamp_rsc_table/remote/prj.conf

samples/subsys/ipc/openamp_rsc_table/remote/src/main_remote.c

arnopo · 2020-02-06T14:23:48Z

@galak: gentle reminder. This PR still waits your review :)

jhedberg · 2020-03-12T08:55:37Z

This seems to have been neglected for awhile. I just triggered a Shippable re-run. @galak could you take a look?

galak

In general looks good, a few updates based on changes I made to PR #17553 that we should reflect here.

lib/open-amp/rsc_table/Kconfig

lib/open-amp/rsc_table/README

lib/open-amp/rsc_table/resource_table.c

samples/subsys/ipc/openamp_rsc_table/remote/CMakeLists.txt

samples/subsys/ipc/openamp_rsc_table/remote/stm32mp157c_dk2.overlay

soc/arm/st_stm32/stm32mp1/dts_fixup.h

galak

Do you see having more things in lib/open-amp/. Wonder if we need the rsc_table dir, or if we can flatten things a little?

arnopo · 2020-03-26T17:48:57Z

Thanks @galak for the review, i will push a new version ASAP ( likely tomorrow)

arnopo · 2020-03-26T18:14:39Z

Do you see having more things in lib/open-amp/. Wonder if we need the rsc_table dir, or if we can flatten things a little?

No more things it pipe for the moment, ok i will suppress the rsc_dtable dir

arnopo · 2020-03-27T13:56:09Z

Do you see having more things in lib/open-amp/. Wonder if we need the rsc_table dir, or if we can flatten things a little?

No more things it pipe for the moment, ok i will suppress the rsc_dtable dir

rsc_table dir has been suppressed

lib/open-amp/CMakeLists.txt

samples/subsys/ipc/openamp_rsc_table/CMakeLists.txt

galak

In general looks good, some minor updates. Should we get PR #14750 merged first, after which I think this should be good.

lib/open-amp/README

arnopo · 2020-03-27T17:16:39Z

Shippable issue seems not linked to this PR:

INFO    - 435/782 mps2_an385                tests/net/socket/select/net.socket.select          FAILED Failed (qemu 5.352s)
INFO    - /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/sanity-out/mps2_an385/tests/net/socket/select/net.socket.select/handler.log
ERROR   - *** Booting Zephyr OS build zephyr-v2.2.0-812-g60dd11610e6d  ***
Running test suite socket_select
===================================================================
starting test - test_fd_set
PASS - test_fd_set
===================================================================
starting test - test_select

    Assertion failed at WEST_TOPDIR/zephyr/tests/net/socket/select/src/main.c:115: test_select: (tstamp >= 30U && tstamp <= 30 + FUZZ is false)

arnopo · 2020-03-31T07:26:05Z

Shippable issue seems not linked to this PR:

INFO    - 435/782 mps2_an385                tests/net/socket/select/net.socket.select          FAILED Failed (qemu 5.352s)
INFO    - /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/sanity-out/mps2_an385/tests/net/socket/select/net.socket.select/handler.log
ERROR   - *** Booting Zephyr OS build zephyr-v2.2.0-812-g60dd11610e6d  ***
Running test suite socket_select
===================================================================
starting test - test_fd_set
PASS - test_fd_set
===================================================================
starting test - test_select

    Assertion failed at WEST_TOPDIR/zephyr/tests/net/socket/select/src/main.c:115: test_select: (tstamp >= 30U && tstamp <= 30 + FUZZ is false)

outdated as solve by a rebase

samples/subsys/ipc/openamp_rsc_table/CMakeLists.txt

The resource table is needed by the Linux kernel OS for a rpmsg generic support, but is also recognised by OpenAMP. This table allows to add trace based on the RAM console and to support rpmsg protocol. Signed-off-by: Arnaud Pouliquen <[email protected]>

Rebase the resource table management to the new implementation in open-amp module Signed-off-by: Arnaud Pouliquen <[email protected]>

64 kB of memory is reserved for the inter-processor communication. this makes sense only if RPMsg is used. Allow to use this memory for firmware data by default. Signed-off-by: Arnaud Pouliquen <[email protected]>

This sample is designed to respond to the Linux rpmsg sample client. It should be platform independent and based on the the integration of a resource table in the elf file. Signed-off-by: Arnaud Pouliquen <[email protected]>

arnopo · 2020-04-01T08:10:56Z

@galak,
i tested your updates and rebase to force the re-run of some stalled checks,

arnopo requested review from dbkinder, erwango, galak, MaureenHelm and nashif as code owners June 21, 2019 15:52

zephyrbot added area: Devicetree area: Boards area: Samples Samples area: Modules labels Jun 21, 2019

This comment has been minimized.

Sign in to view

arnopo force-pushed the OpenAMP_rsc_table_sample branch 2 times, most recently from e6107de to 52e12c1 Compare June 21, 2019 16:24

dbkinder suggested changes Jun 22, 2019

View reviewed changes

samples/subsys/ipc/openamp_rsc_table/README.rst Outdated Show resolved Hide resolved

samples/subsys/ipc/openamp_rsc_table/README.rst Outdated Show resolved Hide resolved

samples/subsys/ipc/openamp_rsc_table/README.rst Outdated Show resolved Hide resolved

arnopo force-pushed the OpenAMP_rsc_table_sample branch from 52e12c1 to 5b2350b Compare June 24, 2019 12:35

arnopo force-pushed the OpenAMP_rsc_table_sample branch from 5b2350b to 905f828 Compare June 24, 2019 13:02

dbkinder suggested changes Jun 25, 2019

View reviewed changes

samples/subsys/ipc/openamp_rsc_table/README.rst Outdated Show resolved Hide resolved

samples/subsys/ipc/openamp_rsc_table/README.rst Outdated Show resolved Hide resolved

samples/subsys/ipc/openamp_rsc_table/README.rst Outdated Show resolved Hide resolved

arnopo force-pushed the OpenAMP_rsc_table_sample branch from 905f828 to c41d24d Compare June 26, 2019 15:04

arnopo mentioned this pull request Jun 28, 2019

board: suppress useless config in Avenger96 board #17148

Merged

dbkinder approved these changes Jul 2, 2019

View reviewed changes

arnopo force-pushed the OpenAMP_rsc_table_sample branch from c41d24d to ab5119e Compare July 3, 2019 09:30

arnopo added the area: IPC Inter-Process Communication label Jul 3, 2019

erwango requested changes Jul 5, 2019

View reviewed changes

yboutreux reviewed Jul 15, 2019

View reviewed changes

samples/subsys/ipc/openamp_rsc_table/remote/src/main_remote.c Outdated Show resolved Hide resolved

arnopo force-pushed the OpenAMP_rsc_table_sample branch from ab5119e to 088a1b9 Compare July 16, 2019 15:00

arnopo mentioned this pull request Jul 16, 2019

Open amp refactoring and add more platforms support #17553

Merged

erwango self-requested a review July 22, 2019 09:52

arnopo force-pushed the OpenAMP_rsc_table_sample branch 3 times, most recently from 0c918c1 to f0591c6 Compare July 25, 2019 15:30

arnopo force-pushed the OpenAMP_rsc_table_sample branch 3 times, most recently from 8b1a36e to b85f849 Compare February 6, 2020 15:28

galak force-pushed the OpenAMP_rsc_table_sample branch from b85f849 to 2add631 Compare March 25, 2020 18:08

galak requested changes Mar 26, 2020

View reviewed changes

galak reviewed Mar 26, 2020

View reviewed changes

arnopo force-pushed the OpenAMP_rsc_table_sample branch from 2add631 to a649b16 Compare March 27, 2020 13:53

galak reviewed Mar 27, 2020

View reviewed changes

lib/open-amp/CMakeLists.txt Show resolved Hide resolved

galak reviewed Mar 27, 2020

View reviewed changes

samples/subsys/ipc/openamp_rsc_table/CMakeLists.txt Outdated Show resolved Hide resolved

galak reviewed Mar 27, 2020

View reviewed changes

arnopo commented Mar 27, 2020

View reviewed changes

lib/open-amp/README Outdated Show resolved Hide resolved

arnopo force-pushed the OpenAMP_rsc_table_sample branch from a649b16 to 2c52aa7 Compare March 27, 2020 16:16

galak force-pushed the OpenAMP_rsc_table_sample branch from 2c52aa7 to a5e3033 Compare March 27, 2020 20:22

galak reviewed Apr 1, 2020

View reviewed changes

samples/subsys/ipc/openamp_rsc_table/CMakeLists.txt Outdated Show resolved Hide resolved

galak force-pushed the OpenAMP_rsc_table_sample branch from a5e3033 to a4f0eba Compare April 1, 2020 02:30

galak approved these changes Apr 1, 2020

View reviewed changes

arnopo added 4 commits April 1, 2020 09:45

stm32mp1: update resource table management

cb41aa7

Rebase the resource table management to the new implementation in open-amp module Signed-off-by: Arnaud Pouliquen <[email protected]>

dts: extend stm32mp1 sram declaration to 300 kB by default

09bac32

64 kB of memory is reserved for the inter-processor communication. this makes sense only if RPMsg is used. Allow to use this memory for firmware data by default. Signed-off-by: Arnaud Pouliquen <[email protected]>

samples: add openamp sample relying on resource table

6d2865e

This sample is designed to respond to the Linux rpmsg sample client. It should be platform independent and based on the the integration of a resource table in the elf file. Signed-off-by: Arnaud Pouliquen <[email protected]>

arnopo force-pushed the OpenAMP_rsc_table_sample branch from a4f0eba to 6d2865e Compare April 1, 2020 07:59

galak merged commit f6800aa into zephyrproject-rtos:master Apr 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenAMP rsc table sample #16985

OpenAMP rsc table sample #16985

arnopo commented Jun 21, 2019 •

edited

Loading

This comment has been minimized.

arnopo commented Jun 24, 2019

dbkinder left a comment

erwango left a comment

arnopo commented Feb 6, 2020 •

edited

Loading

jhedberg commented Mar 12, 2020

galak left a comment

galak left a comment

arnopo commented Mar 26, 2020

arnopo commented Mar 26, 2020

arnopo commented Mar 27, 2020

galak left a comment

arnopo commented Mar 27, 2020

arnopo commented Mar 31, 2020

arnopo commented Apr 1, 2020

OpenAMP rsc table sample #16985

OpenAMP rsc table sample #16985

Conversation

arnopo commented Jun 21, 2019 • edited Loading

This comment has been minimized.

arnopo commented Jun 24, 2019

dbkinder left a comment

Choose a reason for hiding this comment

erwango left a comment

Choose a reason for hiding this comment

arnopo commented Feb 6, 2020 • edited Loading

jhedberg commented Mar 12, 2020

galak left a comment

Choose a reason for hiding this comment

galak left a comment

Choose a reason for hiding this comment

arnopo commented Mar 26, 2020

arnopo commented Mar 26, 2020

arnopo commented Mar 27, 2020

galak left a comment

Choose a reason for hiding this comment

arnopo commented Mar 27, 2020

arnopo commented Mar 31, 2020

arnopo commented Apr 1, 2020

arnopo commented Jun 21, 2019 •

edited

Loading

arnopo commented Feb 6, 2020 •

edited

Loading