resource table: add helper to add resource table in project. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource table is needed by the Linux kernel OS for a rpmsg generic support, but is also recognised by OpenAMP. This table allows to add trace based on the RAM console and to support rpmsg protocol. Signed-off-by: Arnaud Pouliquen <[email protected]>
|
@galak can you take a look? |
galak
reviewed
Sep 17, 2019
| @@ -0,0 +1,59 @@ | |||
| /* | |||
There was a problem hiding this comment.
I feel like these files would be better to live in the Zephyr code base and not here. So maybe adding them in lib/open-amp/
There was a problem hiding this comment.
Thanks for the suggestion. I was not convince either that this was the best place for these files....
So I'll move them, and close this pull request
galak
requested changes
Sep 17, 2019
@galak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource table is needed by the Linux kernel OS
for rpmsg generic support, but is also recognised by OpenAMP.
This table allows to add trace based on the RAM console
and to support rpmsg protocol.
Signed-off-by: Arnaud Pouliquen [email protected]