-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dts_fixup: Remove redefined CONFIG_WDT_0_NAME #11331
dts_fixup: Remove redefined CONFIG_WDT_0_NAME #11331
Conversation
The marco 'CONFIG_WDT_0_NAME' are defined in Kconfig, doesn't need defined in dts_fixup.h Signed-off-by: qianfan Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik it should be removed from kconfig or disabled for drivers enabling DTS. It should come from DTS at the end.
Codecov Report
@@ Coverage Diff @@
## master #11331 +/- ##
=======================================
Coverage 51.58% 51.58%
=======================================
Files 216 216
Lines 27671 27671
Branches 6938 6938
=======================================
Hits 14274 14274
Misses 10648 10648
Partials 2749 2749 Continue to review full report at Codecov.
|
I'm with Anas, that I'd rather we remove the Kconfig option instead of removing this from DT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove option from Kconfig then?
I should waiting all the watchdog drivers support DT. Then can remove the Kconfig options. Some soc driver doesn't support watchdog dts(such as sam) |
Just a quick look for SAM, we have dts/bindings/watchdog/atmel,sam-watchdog.yaml. Do we not use DT for it? |
@galak Sorry it's my wrong. Seems what I need to is remove the Kconfig options and add somethings like this in dts_fixup.h
|
yeah, take a look at #11377 |
all those changes do not apply anymore. |
The marco 'CONFIG_WDT_0_NAME' are defined in Kconfig, doesn't need
defined in dts_fixup.h
Signed-off-by: qianfan Zhao [email protected]