Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts_fixup: Remove redefined CONFIG_WDT_0_NAME #11331

Conversation

qianfan-Zhao
Copy link
Collaborator

The marco 'CONFIG_WDT_0_NAME' are defined in Kconfig, doesn't need
defined in dts_fixup.h

Signed-off-by: qianfan Zhao [email protected]

The marco 'CONFIG_WDT_0_NAME' are defined in Kconfig, doesn't need
defined in dts_fixup.h

Signed-off-by: qianfan Zhao <[email protected]>
Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik it should be removed from kconfig or disabled for drivers enabling DTS. It should come from DTS at the end.

@codecov-io
Copy link

Codecov Report

Merging #11331 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11331   +/-   ##
=======================================
  Coverage   51.58%   51.58%           
=======================================
  Files         216      216           
  Lines       27671    27671           
  Branches     6938     6938           
=======================================
  Hits        14274    14274           
  Misses      10648    10648           
  Partials     2749     2749

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f9dc7...ce202fa. Read the comment docs.

@galak
Copy link
Collaborator

galak commented Nov 13, 2018

I'm with Anas, that I'd rather we remove the Kconfig option instead of removing this from DT.

Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove option from Kconfig then?

@qianfan-Zhao
Copy link
Collaborator Author

I should waiting all the watchdog drivers support DT. Then can remove the Kconfig options.

Some soc driver doesn't support watchdog dts(such as sam)

@galak
Copy link
Collaborator

galak commented Nov 14, 2018

I should waiting all the watchdog drivers support DT. Then can remove the Kconfig options.

Some soc driver doesn't support watchdog dts(such as sam)

Just a quick look for SAM, we have dts/bindings/watchdog/atmel,sam-watchdog.yaml. Do we not use DT for it?

@qianfan-Zhao
Copy link
Collaborator Author

qianfan-Zhao commented Nov 14, 2018

@galak Sorry it's my wrong.

Seems what I need to is remove the Kconfig options and add somethings like this in dts_fixup.h

#define CONFIG_WDT_0_NAME CONFIG_WDT_SAM_LABEL

@galak
Copy link
Collaborator

galak commented Nov 14, 2018

Seems what I need to is remove the Kconfig options and add somethings like this in dts_fixup.h

yeah, take a look at #11377

@nashif
Copy link
Member

nashif commented Sep 5, 2019

all those changes do not apply anymore.

@nashif nashif closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants