Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert iwdg_stm32 STM32 Watchdog driver to new API #10917

Closed
galak opened this issue Oct 29, 2018 · 6 comments
Closed

Convert iwdg_stm32 STM32 Watchdog driver to new API #10917

galak opened this issue Oct 29, 2018 · 6 comments
Assignees
Labels
area: API Changes to public APIs area: Watchdog Watchdog bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: medium Medium impact/importance bug
Milestone

Comments

@galak
Copy link
Collaborator

galak commented Oct 29, 2018

We have a new driver API for watchdog, the old API has been deprecated for several releases now. We need to convert the driver to use the API or remove it.

@galak galak added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug area: Watchdog Watchdog platform: STM32 ST Micro STM32 area: API Changes to public APIs labels Oct 29, 2018
@galak galak added this to the v1.14.0 milestone Oct 29, 2018
@galak galak assigned erwango and unassigned erwango Oct 29, 2018
@galak
Copy link
Collaborator Author

galak commented Oct 29, 2018

@apodogrocki can you look at update the driver?

@galak galak changed the title Convert iwdg_stm32 SAM Watchdog driver to new API Convert iwdg_stm32 STM32 Watchdog driver to new API Nov 13, 2018
@qianfan-Zhao
Copy link
Collaborator

I will do it

@apodogrocki
Copy link
Contributor

@qianfan-Zhao I've already started working on that. If you would like you can think of adding window mode to the Independent Watchdog driver. It has never been activated, but can be useful. That probably requires separate PR.

@erwango @galak There is also a question how to provide support for System Window Watchdog. All watchdog devices are named "WATCHDOG_0" at the moment. In case of STM32 can both IWDG & WWDG co-exist in the same time? Or Kconfig.stm32 should contain choice menu to select desired watchdog type?

@qianfan-Zhao
Copy link
Collaborator

qianfan-Zhao commented Nov 14, 2018

here is also a question how to provide support for System Window Watchdog. All watchdog devices are named "WATCHDOG_0" at the moment.

Currently the name of watchdog are defined in Kconfig. Based on the comments in #11331 we should remove the Kconfig options and make DT define the name of watchdog.

Others SoC such as NRF has this lines in dts_fixup.h:

#define CONFIG_WDT_0_NAME		DT_NORDIC_NRF_WATCHDOG_40010000_LABEL

If there has 2 watchdogs, such as IWDG and WWDG, i think it OK to define the difference name in DT:

#define CONFIG_WDT_0_NAME DT_STM32_IWDG_XXX_LABEL
#define CONFIG_WDT_1_NAME DT_STM32_WWDG_XXX_LABEL

@apodogrocki
Copy link
Contributor

@qianfan-Zhao Ok, I see that you have better insight in the current Zephyr code than me. So maybe it is correct that you should take care of this task. After all it seems that @galak has already made a decision.

@galak
Copy link
Collaborator Author

galak commented Nov 14, 2018

@qianfan-Zhao Ok, I see that you have better insight in the current Zephyr code than me. So maybe it is correct that you should take care of this task. After all it seems that @galak has already made a decision.

Sorry, I got confused by the thread, and so I assigned it to @qianfan-Zhao. I'm happy for either of you guys to get this driver updated. I don't think @apodogrocki was a collaborator of the project, so couldn't add you :).

erwango pushed a commit to qianfan-Zhao/zephyr that referenced this issue Feb 1, 2019
@nashif nashif closed this as completed in 107375d Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: Watchdog Watchdog bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants