drivers: watchdog: Adding watchdog support for sam SOC #10828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subbu147
requested review from
dbkinder,
galak and
MaureenHelm
as code owners
Codecov Report
@@ Coverage Diff @@
## master #10828 +/- ##
==========================================
+ Coverage 53.21% 53.3% +0.08%
==========================================
Files 217 215 -2
Lines 26667 25908 -759
Branches 5913 5711 -202
==========================================
- Hits 14192 13810 -382
+ Misses 10059 9777 -282
+ Partials 2416 2321 -95
Continue to review full report at Codecov.
|
subbu147
force-pushed
the
sam3x8e_watchdog
branch
from
ef9c216 to
9fefd3d
Compare
subbu147
changed the title
dbkinder
approved these changes
Oct 25, 2018
subbu147
force-pushed
the
sam3x8e_watchdog
branch
from
9fefd3d to
f25a3a0
Compare
galak
reviewed
Oct 30, 2018
galak
force-pushed
the
sam3x8e_watchdog
branch
3 times, most recently
from
11aa6ed to
601f9dd
Compare
|
I pushed some updates and reworked the driver a bit, take a look and test it out if you can. |
nashif
previously requested changes
Oct 30, 2018
subbu147
force-pushed
the
sam3x8e_watchdog
branch
from
601f9dd to
9dd6382
Compare
galak
dismissed
nashif’s stale review
Issue resolved, dropped change to prj.conf
|
@subbu147 did my changes look good? did they test out ok? |
|
@galak Your changes holds good. I have tested All the modes and all the new negative(fault handling) scenarios. |
galak
force-pushed
the
sam3x8e_watchdog
branch
from
9dd6382 to
88300f2
Compare
galak
approved these changes
Oct 31, 2018
MaureenHelm
requested changes
Oct 31, 2018
subbu147
force-pushed
the
sam3x8e_watchdog
branch
from
88300f2 to
1576ac8
Compare
|
@MaureenHelm can you re-review |
MaureenHelm
requested changes
Nov 1, 2018
Adding watchdog driver for sam SoC. The current implemntation just diables the watchdog on device boot. This PR adds the following support for SAM3X, SAM4S and SAME70 1. Activate processor reset 2. Activate all reset 3. Generate interrupt on watchdog timer expiration. Signed-off-by: Subramanian Meenakshi Sundaram <[email protected]> Signed-off-by: Kumar Gala <[email protected]>
subbu147
force-pushed
the
sam3x8e_watchdog
branch
from
1576ac8 to
07310bf
Compare
MaureenHelm
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding watchdog driver for sam SoC. The current implementation just
disables the watchdog on device boot.
This PR adds the following support for SAM3X, SAM4S and SAME70
on watchdog timer expiration.
Signed-off-by: Subramanian Meenakshi Sundaram [email protected]