Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Atmel SAM Watchdog driver to new API #10913

Closed
galak opened this issue Oct 29, 2018 · 5 comments
Closed

Convert Atmel SAM Watchdog driver to new API #10913

galak opened this issue Oct 29, 2018 · 5 comments
Labels
area: API Changes to public APIs area: Watchdog Watchdog bug The issue is a bug, or the PR is fixing a bug platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) priority: medium Medium impact/importance bug
Milestone
v1.14.0

Comments

@galak
Copy link
Collaborator

galak commented Oct 29, 2018

We have a new driver API for watchdog, the old API has been deprecated for several releases now. We need to convert the driver to use the API or remove it.
@galak galak added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug area: Watchdog Watchdog area: API Changes to public APIs platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Oct 29, 2018
@galak galak added this to the v1.14.0 milestone Oct 29, 2018
@subbu147
Copy link
Contributor

Hi Kumar,
I have done in it PR #10828. Can you please take a look at it.

@galak
Copy link
Collaborator Author

galak commented Oct 30, 2018

@subbu147 thanks for the update. I've made some cleanups and enhancements. Take a look, and if you can test it out, that would be great.

@galak galak mentioned this issue Oct 30, 2018
Closed
33 tasks
@subbu147
Copy link
Contributor

@galak I have tested it and made some small modifications as well. Please take a look when you get a chance.

@subbu147
Copy link
Contributor

subbu147 commented Nov 2, 2018 •
edited
Loading

@galak This issue can be closed now as its addressed by PR #10828.

@galak
Copy link
Collaborator Author

galak commented Nov 3, 2018

Resolved by merge of #10828

@galak galak closed this as completed Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: API Changes to public APIs area: Watchdog Watchdog bug The issue is a bug, or the PR is fixing a bug platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v1.14.0
Development

No branches or pull requests
2 participants
@subbu147 @galak