Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

same70b: patch: Fix SMC struct naming #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AsgeirSH
Copy link

@AsgeirSH AsgeirSH commented Sep 6, 2024

Renames SmcCs struct names and defines to match the names for SAM4S, since the existing memc-sam-driver is built on SAM4S.

Fixes a build failure when adding support for the SMC peripheral to the same70-dts.

See also related PR in main Zephyr-repo.

Note that I've only done this change in the same70b-files, as that is the hardware I've had to test it with. It should probably be the same for same70 and maybe samv71 / samv71b - as far as I could tell from a quick glance it has the same issues (and the SMC peripheral is the same for this entire series).

@nandojve
Copy link
Member

nandojve commented Sep 7, 2024

Hi @AsgeirSH,

Patch LGTM. You need apply this for all four: same70(b) and samv71(b). Otherwise this will broke for the remaining 3.
Provide the others as individuals commits.

@nandojve nandojve changed the title same70b: patch: Fix SmcCs struct naming to match Zephyr sam-smc driver same70b: patch: Fix SMC struct naming Sep 7, 2024
@AsgeirSH
Copy link
Author

AsgeirSH commented Sep 8, 2024

Hi @nandojve,

Thanks for the feedback. Should be fixed now, also updated the driver PR to check for SAMV71-series SOC.

@nandojve
Copy link
Member

nandojve commented Sep 9, 2024

Hi @AsgeirSH ,

Thank you for these changes. You need to fix the commits because we are not fixing the naming to match Zephyr expectation, that is the outcome of these changes. Take in consideration that this repo "have zero knowledge of zephyr existence".

-same70b: patch: Fix SmcCs struct naming to match Zephyr driver
+same70b: patch: Fix SmcCs struct naming
-Fixes a build failure when adding support for the SMC peripheral to the same70b-dts.
+This commit patches the incorrect SMC struct name

Asgeir Stavik Hustad added 3 commits September 9, 2024 19:28
This commit patches the incorrect SMC struct name.

Signed-off-by: Asgeir Stavik Hustad <[email protected]>
This commit patches the incorrect SMC struct name for same70.

Signed-off-by: Asgeir Stavik Hustad <[email protected]>
This commit patches the incorrect SMC struct name.

Signed-off-by: Asgeir Stavik Hustad <[email protected]>
@nandojve
Copy link
Member

Hi @AsgeirSH ,

Is there any reason for the samv71b: patch: Fix SMC struct naming brief be different from the others?
Would you mind to make then equal?

This commit patches the incorrect SMC struct name.

Signed-off-by: Asgeir Stavik Hustad <[email protected]>
@AsgeirSH
Copy link
Author

No reason, just missed that while editing I guess. Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants