-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
same70b: patch: Fix SMC struct naming #41
base: master
Are you sure you want to change the base?
Conversation
Hi @AsgeirSH, Patch LGTM. You need apply this for all four: same70(b) and samv71(b). Otherwise this will broke for the remaining 3. |
Hi @nandojve, Thanks for the feedback. Should be fixed now, also updated the driver PR to check for SAMV71-series SOC. |
Hi @AsgeirSH , Thank you for these changes. You need to fix the commits because we are not fixing the naming to match Zephyr expectation, that is the outcome of these changes. Take in consideration that this repo "have zero knowledge of zephyr existence". -same70b: patch: Fix SmcCs struct naming to match Zephyr driver
+same70b: patch: Fix SmcCs struct naming
-Fixes a build failure when adding support for the SMC peripheral to the same70b-dts.
+This commit patches the incorrect SMC struct name |
This commit patches the incorrect SMC struct name. Signed-off-by: Asgeir Stavik Hustad <[email protected]>
This commit patches the incorrect SMC struct name for same70. Signed-off-by: Asgeir Stavik Hustad <[email protected]>
This commit patches the incorrect SMC struct name. Signed-off-by: Asgeir Stavik Hustad <[email protected]>
b775a06
to
3bab2df
Compare
Hi @AsgeirSH , Is there any reason for the |
This commit patches the incorrect SMC struct name. Signed-off-by: Asgeir Stavik Hustad <[email protected]>
3bab2df
to
2527282
Compare
No reason, just missed that while editing I guess. Fixed now. |
Renames SmcCs struct names and defines to match the names for SAM4S, since the existing memc-sam-driver is built on SAM4S.
Fixes a build failure when adding support for the SMC peripheral to the same70-dts.
See also related PR in main Zephyr-repo.
Note that I've only done this change in the same70b-files, as that is the hardware I've had to test it with. It should probably be the same for same70 and maybe samv71 / samv71b - as far as I could tell from a quick glance it has the same issues (and the SMC peripheral is the same for this entire series).