fix: reset database for sqlite and windows #747
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
test/add-windows-permutation
branch
19 times, most recently
from
3db8b8a to
4b67273
Compare
nikophil
force-pushed
the
test/add-windows-permutation
branch
from
4b67273 to
bab835a
Compare
nikophil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #746
I found the fix thanks to laravel/framework#21720
At start, I wanted to add a unique CI permutation with windows, but it is incompatible with this, we're getting an error "Container operations are only supported on Linux runners".
The only solution would be to add yet another job, which I'm reluctant to do. But the tests actually passed with a window runner. Let's say we'll add this new job if a new bug with windows occurs