Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Don't recreate the SQLite database file #21720

Merged
merged 1 commit into from
Oct 18, 2017
Merged

[5.5] Don't recreate the SQLite database file #21720

merged 1 commit into from
Oct 18, 2017

Conversation

KristofMorva
Copy link
Contributor

@KristofMorva KristofMorva commented Oct 17, 2017

Unlinking and touching the sqlite file will change the permission/owner/group of the database file, which can cause issues in environments like Docker.
Instead, we can just empty the file.

Seems to be a fix for laravel/dusk#359

@alexeycrystal
Copy link

Hi!
It's a really nice solution. Thanks!

@taylorotwell taylorotwell merged commit cfc7483 into laravel:5.5 Oct 18, 2017
@AdamEsterle
Copy link

AdamEsterle commented Oct 18, 2017

@KristofMorva Works great! Thanks!

@KristofMorva KristofMorva deleted the sqlite-refresh branch October 18, 2017 16:12
@deleugpn
Copy link
Contributor

Elegant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants