Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kaniko image builder service account passing #3081

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Oct 14, 2024

Describe changes

The service account was incorrectly being passed to the container instead of the pod spec.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@schustmi schustmi requested a review from htahir1 October 14, 2024 11:58
@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Oct 14, 2024
Copy link
Contributor

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

Copy link
Contributor

Classification template updates in examples/mlops_starter have been pushed.

Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

@schustmi schustmi merged commit f5d3908 into develop Oct 17, 2024
4 checks passed
@schustmi schustmi deleted the bugfix/kaniko-service-account branch October 17, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants