Skip to content

Commit

Permalink
Fix Kaniko image builder service account passing (#3081)
Browse files Browse the repository at this point in the history
* Pass Kaniko service account correctly

* Auto-update of LLM Finetuning template

* Auto-update of Starter template

* Auto-update of E2E template

---------

Co-authored-by: GitHub Actions <[email protected]>
  • Loading branch information
schustmi and actions-user authored Oct 17, 2024
1 parent 3f0699f commit f5d3908
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ def _generate_spec_overrides(
"--image-name-with-digest-file=/dev/termination-log",
] + self.config.executor_args

optional_container_args: Dict[str, Any] = {}
optional_spec_args: Dict[str, Any] = {}
if self.config.service_account_name:
optional_container_args["serviceAccountName"] = (
optional_spec_args["serviceAccountName"] = (
self.config.service_account_name
)

Expand All @@ -218,10 +218,10 @@ def _generate_spec_overrides(
"env": self.config.env,
"envFrom": self.config.env_from,
"volumeMounts": self.config.volume_mounts,
**optional_container_args,
}
],
"volumes": self.config.volumes,
**optional_spec_args,
},
}

Expand Down

0 comments on commit f5d3908

Please sign in to comment.