Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn synchronous mode on by default for all orchestrators #1991

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Turn synchronous mode on by default for all orchestrators #1991

merged 1 commit into from
Oct 26, 2023

Conversation

stefannica
Copy link
Contributor

Describe changes

Turn synchronous mode on by default for all orchestrators (for a better default user experience).

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Oct 26, 2023
htahir1
htahir1 requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings need changing accordingly :-)

strickvl
strickvl requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @htahir1 said. Otherwise LGTM.

@stefannica stefannica force-pushed the feature/turn-sync-on-by-default branch from ccc1d35 to 70d34dd Compare October 26, 2023 15:15
@stefannica stefannica merged commit e50db79 into develop Oct 26, 2023
29 checks passed
@stefannica stefannica deleted the feature/turn-sync-on-by-default branch October 26, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

@strickvl strickvl strickvl approved these changes

@AlexejPenner AlexejPenner Awaiting requested review from AlexejPenner

Assignees
No one assigned
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefannica @strickvl @htahir1