Skip to content

Commit

Permalink
Turn synchronous mode on by default for all orchestrators
Browse files Browse the repository at this point in the history
  • Loading branch information
stefannica committed Oct 26, 2023
1 parent 7c45c9a commit 70d34dd
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,10 @@ class SagemakerOrchestratorConfig( # type: ignore[misc] # https://github.com/py
loaded from the default AWS config.
Attributes:
synchronous: Whether to run the processing job synchronously or
asynchronously. Defaults to False.
synchronous: If `True`, the client running a pipeline using this
orchestrator waits until all steps finish running. If `False`,
the client returns immediately and the pipeline is executed
asynchronously. Defaults to `True`.
execution_role: The IAM role ARN to use for the pipeline.
aws_access_key_id: The AWS access key ID to use to authenticate to AWS.
If not provided, the value from the default AWS config will be used.
Expand All @@ -117,7 +119,7 @@ class SagemakerOrchestratorConfig( # type: ignore[misc] # https://github.com/py
"sagemaker-{region}-{aws-account-id}".
"""

synchronous: bool = False
synchronous: bool = True
execution_role: str
aws_access_key_id: Optional[str] = SecretField()
aws_secret_access_key: Optional[str] = SecretField()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ class VertexOrchestratorSettings(BaseSettings):
"""Settings for the Vertex orchestrator.
Attributes:
synchronous: If `True`, running a pipeline using this orchestrator will
block until all steps finished running on Vertex AI Pipelines
service.
synchronous: If `True`, the client running a pipeline using this
orchestrator waits until all steps finish running. If `False`,
the client returns immediately and the pipeline is executed
asynchronously. Defaults to `True`.
labels: Labels to assign to the pipeline job.
node_selector_constraint: Each constraint is a key-value pair label.
For the container to be eligible to run on a node, the node must have
Expand All @@ -53,7 +54,7 @@ class VertexOrchestratorSettings(BaseSettings):
"""

labels: Dict[str, str] = {}
synchronous: bool = False
synchronous: bool = True
node_selector_constraint: Optional[Tuple[str, str]] = None
pod_settings: Optional[KubernetesPodSettings] = None

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ class KubeflowOrchestratorSettings(BaseSettings):
"""Settings for the Kubeflow orchestrator.
Attributes:
synchronous: If `True`, running a pipeline using this orchestrator will
block until all steps finished running on KFP. This setting only
synchronous: If `True`, the client running a pipeline using this
orchestrator waits until all steps finish running. If `False`,
the client returns immediately and the pipeline is executed
asynchronously. Defaults to `True`. This setting only
has an effect when specified on the pipeline and will be ignored if
specified on steps.
timeout: How many seconds to wait for synchronous runs.
Expand All @@ -55,7 +57,7 @@ class KubeflowOrchestratorSettings(BaseSettings):
pod_settings: Pod settings to apply.
"""

synchronous: bool = False
synchronous: bool = True
timeout: int = 1200

client_args: Dict[str, Any] = {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ class KubernetesOrchestratorSettings(BaseSettings):
"""Settings for the Kubernetes orchestrator.
Attributes:
synchronous: If `True`, running a pipeline using this orchestrator will
block until all steps finished running on Kubernetes.
synchronous: If `True`, the client running a pipeline using this
orchestrator waits until all steps finish running. If `False`,
the client returns immediately and the pipeline is executed
asynchronously. Defaults to `True`.
timeout: How many seconds to wait for synchronous runs. `0` means
to wait for an unlimited duration.
service_account_name: Name of the service account to use for the
Expand All @@ -42,7 +44,7 @@ class KubernetesOrchestratorSettings(BaseSettings):
pod_settings: Pod settings to apply.
"""

synchronous: bool = False
synchronous: bool = True
timeout: int = 0
service_account_name: Optional[str] = None
pod_settings: Optional[KubernetesPodSettings] = None
Expand Down

0 comments on commit 70d34dd

Please sign in to comment.