This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Do not re-inject filter/validator chains of inputs pulled from plugin manager #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… manager As reported in zendframework#8, a change in zendframework#2 now causes inputs pulled from the plugin manager within `Factory::createInput()` to be injected with the default filter and validator chains composed in the `Factory`. This can cause filter and validator chains created during construction or within the input's factory to be overwritten entirely. This patch adds conditions to skip injection of the default filter and validator chains on inputs pulled from the input filter manager, while retaining the logic introduced in zendframework#2 to allow values in the `$inputSpecification` to further configure the instance.
weierophinney
added a commit
that referenced
this pull request
Nov 7, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #8, a change in #2 now causes inputs pulled from the plugin manager within
Factory::createInput()to be injected with the default filter and validator chains composed in theFactory. This can cause filter and validator chains created during construction or within the input's factory to be overwritten entirely.This patch adds conditions to skip injection of the default filter and validator chains on inputs pulled from the input filter manager, while retaining the logic introduced in #2 to allow values in the
$inputSpecificationto further configure the instance.Fixes #8.