Do not re-inject filter/validator chains of inputs pulled from plugin…

… manager

As reported in #8, a change in #2 now causes inputs pulled from the
plugin manager within `Factory::createInput()` to be injected with the
default filter and validator chains composed in the `Factory`.
This can cause filter and validator chains created during construction
or within the input's factory to be overwritten entirely.

This patch adds conditions to skip injection of the default filter and
validator chains on inputs pulled from the input filter manager, while
retaining the logic introduced in #2 to allow values in the
`$inputSpecification` to further configure the instance.

src/Factory.php

@@ -189,10 +189,10 @@ public function createInput($inputSpecification)
             ));
         }
 
-        if ($this->defaultFilterChain) {
+        if (! $managerInstance && $this->defaultFilterChain) {
             $input->setFilterChain(clone $this->defaultFilterChain);
         }
-        if ($this->defaultValidatorChain) {
+        if (! $managerInstance && $this->defaultValidatorChain) {
             $input->setValidatorChain(clone $this->defaultValidatorChain);
         }
 

test/FactoryTest.php

@@ -12,6 +12,7 @@
 use Interop\Container\ContainerInterface;
 use PHPUnit_Framework_MockObject_MockObject as MockObject;
 use PHPUnit\Framework\TestCase;
+use Prophecy\Argument;
 use Zend\Filter;
 use Zend\InputFilter\CollectionInputFilter;
 use Zend\InputFilter\Exception\InvalidArgumentException;
@@ -996,6 +997,27 @@ public function testClearDefaultValidatorChain()
         $this->assertNull($factory->getDefaultValidatorChain());
     }
 
+    /**
+     * @see https://github.com/zendframework/zend-inputfilter/issues/8
+     */
+    public function testWhenCreateInputPullsInputFromThePluginManagerItMustNotOverwriteFilterAndValidatorChains()
+    {
+        $input = $this->prophesize(InputInterface::class);
+        $input->setFilterChain(Argument::any())->shouldNotBeCalled();
+        $input->setValidatorChain(Argument::any())->shouldNotBeCalled();
+
+        $pluginManager = $this->prophesize(InputFilterPluginManager::class);
+        $pluginManager->populateFactoryPluginManagers(Argument::type(Factory::class))->shouldBeCalled();
+        $pluginManager->has('Some\Test\Input')->willReturn(true);
+        $pluginManager->get('Some\Test\Input')->will([$input, 'reveal']);
+
+        $spec = ['type' => 'Some\Test\Input'];
+
+        $factory = new Factory($pluginManager->reveal());
+
+        $this->assertSame($input->reveal(), $factory->createInput($spec));
+    }
+
     /**
      * @return Factory
      */