This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Avoid triggering a notice with special crafted accept headers #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theboolean Thanks for your Pull Request! Could you perhaps try to also include a test case as a unit test so we can be sure this bug won't resurface again, for example when someone refactors this class? Thanks! |
theboolean
force-pushed
the
fix/handle-accept-headers-without-equal-sign
branch
from
9015de6
to
9727eb3
Compare
Test correct handling of accept headers with semicolon without equal sign
theboolean
force-pushed
the
fix/handle-accept-headers-without-equal-sign
branch
from
9727eb3
to
851b568
Compare
Test correct handling of accept headers with trailing semicolon
|
Hi @Freeaqingme, I added the test, and as you can see I rewrote the history of my branch putting it before my patch, so it is clear that the test failed before it. |
theboolean
force-pushed
the
fix/handle-accept-headers-without-equal-sign
branch
2 times, most recently
from
0195424
to
cd52116
Compare
Test correct handling of accept headers with trailing semicolon and with semicolon without equal sign
theboolean
force-pushed
the
fix/handle-accept-headers-without-equal-sign
branch
from
cd52116
to
56a297f
Compare
|
Awesome! @weierophinney Given how all tests pass this looks good to me, but I've been out of it for a while. So perhaps this is something you could look at as well? |
|
@theboolean Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid triggering a notice when an accept header without an equal sign is parsed.
Refs #57