Add new tests

Test correct handling of accept headers with trailing semicolon and with semicolon without equal sign
zendframework · May 19, 2016 · cd52116 · cd52116
1 parent b3b51cb
commit cd52116
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/test/Header/AcceptEncodingTest.php b/test/Header/AcceptEncodingTest.php
@@ -31,6 +31,18 @@ public function testAcceptEncodingGetFieldValueReturnsProperValue()
         $acceptEncodingHeader = AcceptEncoding::fromString('Accept-Encoding: xxx');
         $this->assertEquals('xxx', $acceptEncodingHeader->getFieldValue());
     }
+
+    public function testAcceptEncodingGetFieldValueReturnsProperValueWithTrailingSemicolon()
+    {
+        $acceptEncodingHeader = AcceptEncoding::fromString('Accept-Encoding: xxx;');
+        $this->assertEquals('xxx', $acceptEncodingHeader->getFieldValue());
+    }
+
+    public function testAcceptEncodingGetFieldValueReturnsProperValueWithSemicolonWithoutEqualSign()
+    {
+        $acceptEncodingHeader = AcceptEncoding::fromString('Accept-Encoding: xxx;yyy');
+        $this->assertEquals('xxx;yyy', $acceptEncodingHeader->getFieldValue());
+    }
 
     public function testAcceptEncodingToStringReturnsHeaderFormattedString()
     {

diff --git a/test/Header/AcceptLanguageTest.php b/test/Header/AcceptLanguageTest.php
@@ -32,6 +32,18 @@ public function testAcceptLanguageGetFieldValueReturnsProperValue()
         $this->assertEquals('xxx', $acceptLanguageHeader->getFieldValue());
     }
 
+    public function testAcceptLanguageGetFieldValueReturnsProperValueWithTrailingSemicolon()
+    {
+        $acceptLanguageHeader = AcceptLanguage::fromString('Accept-Language: xxx;');
+        $this->assertEquals('xxx', $acceptLanguageHeader->getFieldValue());
+    }
+
+    public function testAcceptLanguageGetFieldValueReturnsProperValueWithSemicolonWithoutEqualSign()
+    {
+        $acceptLanguageHeader = AcceptLanguage::fromString('Accept-Language: xxx;yyy');
+        $this->assertEquals('xxx;yyy', $acceptLanguageHeader->getFieldValue());
+    }
+
     public function testAcceptLanguageToStringReturnsHeaderFormattedString()
     {
         $acceptLanguageHeader = new AcceptLanguage();