This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Response factories #561
Merged
Response factories #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResponseFactory was renamed to ResponseFactoryFactory, and the two test cases were as well.
…st instance Matches response factory and stream factory.
weierophinney
added a commit
that referenced
this pull request
Feb 21, 2018
weierophinney
added a commit
that referenced
this pull request
Feb 21, 2018
Closed
2 tasks
This was referenced Feb 24, 2018
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
ResponseFactoryto be aResponseFactoryFactory. Any class that needs a response instance should compose acallableresponse factory instead, which can then be invoked in order to produce a response. This ensures we generate a new instance every time, and eliminates the need for mapping discrete "virtual" services to the response factory; we can use the same service everywhere.The name chosen for the
ResponseFactoryFactoryservice is the PSR-7ResponseInterface; this allows us to use an existing name instead of a constant evaluating to an arbitrary string name.