This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Added zend-expressive-authentication alpha3 support #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerteltink
reviewed
Feb 24, 2018
composer.json
Outdated
| @@ -21,10 +21,10 @@ | |||
| "php": "^7.1", | |||
| "psr/container": "^1.0", | |||
| "psr/http-message": "^1.0.1", | |||
| "zendframework/zend-expressive-authentication": "^0.1 || ^0.2 || ^1.0.0-dev || ^1.0" | |||
| "zendframework/zend-expressive-authentication": "^1.0.0alpha3" | |||
|
No, check last commit and build before that commit.
…On 24 Feb 2018, 14:12 +0000, Geert Eltink ***@***.***>, wrote:
@xtreamwayz commented on this pull request.
In composer.json:
> @@ -21,10 +21,10 @@
"php": "^7.1",
"psr/container": "^1.0",
"psr/http-message": "^1.0.1",
- "zendframework/zend-expressive-authentication": "^0.1 || ^0.2 || ^1.0.0-dev || ^1.0"
+ "zendframework/zend-expressive-authentication": "^1.0.0alpha3"
Missing ^1.0 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Dropped 0.X support because ResponseInterface is now used as a factory not as a response prototype
If we have "^1.0.0alpha3 || ^1.0" also alpha1 is accepted when install lowest dependencies
weierophinney
added a commit
that referenced
this pull request
Feb 26, 2018
weierophinney
added a commit
that referenced
this pull request
Feb 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: It is PR to master branch because there is no release-1.0.0 branch yet.
We changed recently in zend-expressive that ResponseInterface is factory not a response prototype, see: zendframework/zend-expressive#561
It has been changed only in zend-expressive-authentication release-1.0.0 with alpha3, not in 0.X releases.
This PR drops 0.x branches support.