Implement RouteResultObserverInterface #9
Conversation
Updates UrlHelper to implement RouteResultObserverInterface.
This patch does the following: - Creates a UrlHelperFactory for creating the UrlHelper, to register under the service name `Zend\Expressive\ZendView\UrlHelper` in the application container. (This simplifies usage of the delegator factory). - Updates the ZendViewRendererFactory to test for, and pull when present, the `Zend\Expressive\ZendView\UrlHelper` to create the URL helper. - Provides `ApplicationUrlDelegatorFactory` for injecting the `UrlHelper` as a RouteResult observer to the application instance; to do this, it checks to see if the `Zend\Expressive\ZendView\UrlHelper` is present, and, if so, uses that instance. (This minimizes the number of objects present in the dependency graph for cases when no template renderer is required.)
|
Composer issues. Locally, when I do a fresh install, I get dev-master of Expressive; when Travis runs, it's not getting the update, and thus unable to find the interface. Still searching for a solution. |
As of zendframework/zend-expressive#200, a new interface, `Zend\Expressive\Router\RouteResultObserverInterface` exists to allow notifying instances of the calculated `RouteResult`; this is particularly of interest to URI generators. With zendframework/zend-expressive-zendviewrenderer#9, the zend-view integration provides an observer via the `UrlHelper` it ships, and allows you to attach it to the application via a delegator factory. This patch defines the delegator factory in the template configuration for zend-view, and also details how you would accomplish similar functionality with Pimple.
|
@weierophinney I think there is nothing wrong with composer. See it is looking for rc. And I believe expressive is not yet released another version with the Interface. Either you may want to change it to add minimum-stability flag of dev to the composer.json . So that the root of the package can install dev versions. |
|
@harikt You're looking at the master branch, not this patch; this patch changes the |
| @@ -19,7 +19,7 @@ | |||
| "require": { | |||
| "php": ">=5.5", | |||
| "container-interop/container-interop": "^1.1", | |||
| "zendframework/zend-expressive": "^1.0@rc", | |||
| "zendframework/zend-expressive": "~1.0.0-dev@dev", | |||
There was a problem hiding this comment.
my assumption is this may be problematic when zend-expressive need to download zendviewrenderer. But I am not exactly sure if this will work without minimum-stability flag in expressive. How about you add minimum-stability dev to the composer.json and keep the rest in tact ?
There was a problem hiding this comment.
It will essentially grab dev-master always. I think instead I'm going to tag the zend-expressive repo, and then update this one to the latest tag.
I understand why everyone wanted to separate out the implementations, but while we're not stable, this is a nightmare to maintain the dependencies!
There was a problem hiding this comment.
It will essentially grab dev-master always
Yes only for this repo. But you can change later :) .
and I can understand the pain. There should be some sort of scripts to do automatic releases and tagging when we have many repos.
|
Thank you. I didn't looked that. |
This patch updates the
UrlHelperto implement the new RouteResultObserverInterface.Additionally, it provides a delegator factory for registering the
UrlHelperas aRouteResultobserver to theApplicationinstance, via the following:UrlHelperFactoryfor creating theUrlHelper, to register under the service nameZend\Expressive\ZendView\UrlHelperin the application container. (This simplifies usage of the delegator factory).ZendViewRendererFactoryto test for, and pull when present, theZend\Expressive\ZendView\UrlHelperto create the URL helper.ApplicationUrlDelegatorFactoryfor injecting theUrlHelperas aRouteResultobserver to the application instance; to do this, it checks to see if theZend\Expressive\ZendView\UrlHelperis present, and, if so, uses that instance. (This minimizes the number of objects present in the dependency graph for cases when no template renderer is required.)