This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Prepare for RouteResultObserver updates #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of zendframework/zend-expressive#200, a new interface, `Zend\Expressive\Router\RouteResultObserverInterface` exists to allow notifying instances of the calculated `RouteResult`; this is particularly of interest to URI generators. With zendframework/zend-expressive-zendviewrenderer#9, the zend-view integration provides an observer via the `UrlHelper` it ships, and allows you to attach it to the application via a delegator factory. This patch defines the delegator factory in the template configuration for zend-view, and also details how you would accomplish similar functionality with Pimple.
- Added PHP at `^5.5 || ^7.0` - Modified expressive to `~1.0.0-dev@dev`
Most to `^0.3`, but used `^0.3.1` for zendviewrenderer, as that has a fix specific to the latest changes on expressive.
|
I also performed integration tests, using:
The latter is an issue with the TwigRenderer:
I'm going to see if I can resolve that in the twigrenderer package, so I can specify a working version of that package in the configuration before merging this. |
- ensures a usable version
weierophinney
added a commit
that referenced
this pull request
Dec 3, 2015
weierophinney
added a commit
that referenced
this pull request
Dec 3, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of zendframework/zend-expressive#200, a new interface,
Zend\Expressive\Router\RouteResultObserverInterfaceexists to allow notifying instances of the calculatedRouteResult; this is particularly of interest to URI generators.With zendframework/zend-expressive-zendviewrenderer#9, the zend-view integration provides an observer via the
UrlHelperit ships, and allows you to attach it to the application via a delegator factory.This patch defines the delegator factory in the template configuration for zend-view, and also details how you would accomplish similar functionality with Pimple.