forked from Finschia/finschia-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'rc/v0.47.0-alpha1' into feat/backport_to_main
* rc/v0.47.0-alpha1: (34 commits) ci: update docker action (Finschia#983) fix: revert Finschia#952 (Finschia#984) refactor: refactor x/token,collection query errors (Finschia#980) fix: not to throw error when no txs in block (Finschia#982) chore: change import path to `github.com/Finschia/finschia-sdk` (Finschia#970) fix: remove legacy events on x/collection and x/token (Finschia#966) chore: provide specific error messages on x/collection queries (Finschia#965) fix: check event determinism on original modules (Finschia#963) fix: refactor queries of x/collection and x/token (Finschia#957) chore: address generation of the empty coins in x/foundation (Finschia#952) fix: do not loop enum in x/collection (Finschia#961) fix: fix default next class ids of x/collection (Finschia#960) fix: revert Finschia#955 and add Query/HasParent into x/collection (Finschia#959) fix: replace query errors on the original modules into gRPC ones (Finschia#956) fix: return nil where the parent not exists in x/collection Query/Parent (Finschia#955) fix: remove duplicated events in x/collection Msg/Modify (Finschia#954) fix: allow zero amount of coin in x/collection Query/Balance (Finschia#953) fix: unpack proposals in x/foundation import-genesis (Finschia#947) fix: fix broken x/foundation invariant on treasury (Finschia#946) docs: update comments in the x/token,collection events proto (Finschia#944) ...
- Loading branch information
Showing
1,451 changed files
with
14,272 additions
and
14,467 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,7 @@ representative at an online or offline event. | |
|
|
||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
| reported to the community leaders responsible for enforcement at | ||
| [[email protected]](mailto:[email protected]). | ||
| [[email protected]](mailto:[email protected]). | ||
| All complaints will be reviewed and investigated promptly and fairly. | ||
|
|
||
| All community leaders are obligated to respect the privacy and security of the | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,15 +16,15 @@ | |
| - [Point Release Procedure](#point-release-procedure) | ||
| - [Code Owner Membership](#code-owner-membership) | ||
|
|
||
| Thank you for considering making contributions to lbm-sdk and related | ||
| Thank you for considering making contributions to finschia-sdk and related | ||
| repositories! | ||
|
|
||
| Contributing to this repo can mean many things such as participating in | ||
| discussion or proposing code changes. To ensure a smooth workflow for all | ||
| contributors, the general procedure for contributing has been established: | ||
|
|
||
| 1. Either [open](https://github.com/line/lbm-sdk/issues/new/choose) or | ||
| [find](https://github.com/line/lbm-sdk/issues) an issue you'd like to help with | ||
| 1. Either [open](https://github.com/Finschia/finschia-sdk/issues/new/choose) or | ||
| [find](https://github.com/Finschia/finschia-sdk/issues) an issue you'd like to help with | ||
| 2. Participate in thoughtful discussion on that issue | ||
| 3. If you would like to contribute: | ||
| 1. If the issue is a proposal, ensure that the proposal has been accepted | ||
|
|
@@ -35,7 +35,7 @@ contributors, the general procedure for contributing has been established: | |
| to begin work | ||
| 4. Follow standard Github best practices: fork the repo, branch from the | ||
| HEAD of `main`, make some commits, and submit a PR to `main` | ||
| - For core developers working within the lbm-sdk repo, to ensure a clear | ||
| - For core developers working within the finschia-sdk repo, to ensure a clear | ||
| ownership of branches, branches must be named with the convention | ||
| `{moniker}/{issue#}-branch-name` | ||
| 5. Be sure to submit the PR in `Draft` mode submit your PR early, even if | ||
|
|
@@ -59,7 +59,7 @@ Other notes: | |
| before each commit is available in the `contrib/githooks/` directory. | ||
|
|
||
| ## Commit Convention | ||
| All commits pushed to `lbm-sdk` are classified according to the rules below. | ||
| All commits pushed to `finschia-sdk` are classified according to the rules below. | ||
| Therefore, it cannot be included in the release notes unless you properly assign the prefix to the commit. For example, you can write commit message like `feat: this is new feature`. However, if you want to clarify the scope of the commit, you can write it as follows `feat(x/token): this is new feature`. | ||
| - `chore` : a commit of the type chore makes trivial changes. If you don't want to include specific commit in the release note, add this prefix. | ||
| - `feat` : a commit of the type feat introduces a new feature to the codebase | ||
|
|
@@ -104,20 +104,20 @@ If you open a PR on the LBM SDK, it is mandatory to update the relevant document | |
| ## Forking | ||
|
|
||
| Please note that Go requires code to live under absolute paths, which complicates forking. | ||
| While my fork lives at `https://github.com/someone/lbm-sdk`, | ||
| the code should never exist at `$GOPATH/src/github.com/someone/lbm-sdk`. | ||
| While my fork lives at `https://github.com/someone/finschia-sdk`, | ||
| the code should never exist at `$GOPATH/src/github.com/someone/finschia-sdk`. | ||
| Instead, we use `git remote` to add the fork as a new remote for the original repo, | ||
| `$GOPATH/src/github.com/line/lbm-sdk`, and do all the work there. | ||
| `$GOPATH/src/github.com/Finschia/finschia-sdk`, and do all the work there. | ||
|
|
||
| For instance, to create a fork and work on a branch of it, I would: | ||
|
|
||
| - Create the fork on github, using the fork button. | ||
| - Go to the original repo checked out locally (i.e. `$GOPATH/src/github.com/line/lbm-sdk`) | ||
| - Go to the original repo checked out locally (i.e. `$GOPATH/src/github.com/Finschia/finschia-sdk`) | ||
| - `git remote rename origin upstream` | ||
| - `git remote add origin [email protected]:someone/lbm-sdk.git` | ||
| - `git remote add origin [email protected]:someone/finschia-sdk.git` | ||
|
|
||
| Now `origin` refers to my fork and `upstream` refers to the lbm-sdk version. | ||
| So I can `git push -u origin main` to update my fork, and make pull requests to lbm-sdk from there. | ||
| Now `origin` refers to my fork and `upstream` refers to the finschia-sdk version. | ||
| So I can `git push -u origin main` to update my fork, and make pull requests to finschia-sdk from there. | ||
| Of course, replace `someone` with your git handle. | ||
|
|
||
| To pull in updates from the origin repo, run | ||
|
|
@@ -141,7 +141,7 @@ build, in which case we can fall back on `go mod tidy -v`. | |
|
|
||
| ## Protobuf | ||
|
|
||
| We use [Protocol Buffers](https://developers.google.com/protocol-buffers) along with [gogoproto](https://github.com/gogo/protobuf) to generate code for use in lbm-sdk. | ||
| We use [Protocol Buffers](https://developers.google.com/protocol-buffers) along with [gogoproto](https://github.com/gogo/protobuf) to generate code for use in finschia-sdk. | ||
|
|
||
| For determinstic behavior around Protobuf tooling, everything is containerized using Docker. Make sure to have Docker installed on your machine, or head to [Docker's website](https://docs.docker.com/get-docker/) to install it. | ||
|
|
||
|
|
@@ -216,7 +216,7 @@ should be targeted against the release candidate branch. | |
| - `main` must never fail `make lint test test-race` | ||
| - `main` should not fail `make lint` | ||
| - no `--force` onto `main` (except when reverting a broken commit, which should seldom happen) | ||
| - create a development branch either on github.com/line/lbm-sdk, or your fork (using `git remote add origin`) | ||
| - create a development branch either on github.com/Finschia/finschia-sdk, or your fork (using `git remote add origin`) | ||
| - before submitting a pull request, begin `git rebase` on top of `main` | ||
| ### Pull Merge Procedure | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.