Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: provide specific error messages on x/collection queries #965

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Apr 13, 2023

Description

This patch would make the following queries provide more specific error messages. The error code does not change.

  • Query/TokenType
  • Query/Token

Motivation and context

Reported by @loin3.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #965 (7eaeee0) into rc/v0.47.0-alpha1 (88c4242) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           rc/v0.47.0-alpha1     #965      +/-   ##
=====================================================
+ Coverage              62.51%   62.53%   +0.02%     
=====================================================
  Files                    655      655              
  Lines                  79939    79988      +49     
=====================================================
+ Hits                   49970    50023      +53     
+ Misses                 27286    27283       -3     
+ Partials                2683     2682       -1     
Impacted Files Coverage Δ
simapp/app.go 81.93% <100.00%> (ø)
x/collection/event.go 100.00% <100.00%> (ø)
x/collection/keeper/grpc_query.go 95.03% <100.00%> (+0.56%) ⬆️
x/token/event.go 100.00% <100.00%> (ø)
x/token/keeper/grpc_query.go 96.49% <100.00%> (-0.18%) ⬇️

... and 1 file with indirect coverage changes

@0Tech 0Tech marked this pull request as ready for review April 14, 2023 01:18
@0Tech 0Tech merged commit 79cdf2d into Finschia:rc/v0.47.0-alpha1 Apr 14, 2023
@0Tech 0Tech deleted the collection-error-msg branch April 14, 2023 03:05
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Apr 21, 2023
* rc/v0.47.0-alpha1: (34 commits)
  ci: update docker action (Finschia#983)
  fix: revert Finschia#952 (Finschia#984)
  refactor: refactor x/token,collection query errors (Finschia#980)
  fix: not to throw error when no txs in block (Finschia#982)
  chore: change import path to `github.com/Finschia/finschia-sdk` (Finschia#970)
  fix: remove legacy events on x/collection and x/token (Finschia#966)
  chore: provide specific error messages on x/collection queries (Finschia#965)
  fix: check event determinism on original modules (Finschia#963)
  fix: refactor queries of x/collection and x/token (Finschia#957)
  chore: address generation of the empty coins in x/foundation (Finschia#952)
  fix: do not loop enum in x/collection (Finschia#961)
  fix: fix default next class ids of x/collection (Finschia#960)
  fix: revert Finschia#955 and add Query/HasParent into x/collection (Finschia#959)
  fix: replace query errors on the original modules into gRPC ones (Finschia#956)
  fix: return nil where the parent not exists in x/collection Query/Parent (Finschia#955)
  fix: remove duplicated events in x/collection Msg/Modify (Finschia#954)
  fix: allow zero amount of coin in x/collection Query/Balance (Finschia#953)
  fix: unpack proposals in x/foundation import-genesis (Finschia#947)
  fix: fix broken x/foundation invariant on treasury (Finschia#946)
  docs: update comments in the x/token,collection events proto (Finschia#944)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants