Add streaming API #235
Merged
Add streaming API #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! I think it's fine to have the convenience method. |
|
All fixed now :) Btw, don't rush with the 4.0 release. There are still some things that I think that can be improved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally is here. Streaming API :)
I think that it might fix some of the bugs in https://github.com/zemirco/json2csv-stream
The new architecture also makes the library much more extensible for the users.
One thing that I'm not 100% convince of is whether to leave the
parseconvenience method or just force the users to instantiate a parser. Wdyt??