Change API

[knownasilya]

• Allowing a simpler invocation.

let results = json2csv(data, options)

• Remove callback support
• Return stream, deprecate https://github.com/zemirco/json2csv-stream

json2csv.stream(data, options)
  .pipe(csv)

[knownasilya]

@juanjoDiaz if you are interested in doing the second item as well.

[juanjoDiaz]

Any reason to use stream instead of promises?
Or actually just return since there is nothing async about the library.

[juanjoDiaz]

Nevermind, I see the point. It parses lines one by one and you can even track progress.

I might take a look at it :)

[knownasilya]

@zemirco could you add @juanjoDiaz as a collaborator? Thanks!

[knownasilya]

I've pushed up changes to remove callback support.

[zemirco]

done

[knownasilya]

Thanks! @zemirco could you add him in Github as well?

[zemirco]

done

[juanjoDiaz]

Awesome! Thanks guys. Glad to be helpful :)

[juanjoDiaz]

@zemirco Where did you take the RegExp in https://github.com/zemirco/json2csv-stream/blob/master/index.js#L78 from?

It doesn't seem to work:

 [ '{\n  "field1": {\n    "embeddedField1": "embeddedValue1",\n    "embeddedField2": "embeddedValue2"\n  }',
      '{\n  "field1": {\n    "embeddedField1": "embeddedValue1",\n    "embeddedField2": "embeddedValue2"\n  }',
      '"embeddedValue2"\n  ',
      '2',
      index: 0,
      input: '{\n  "field1": {\n    "embeddedField1": "embeddedValue1",\n    "embeddedField2": "embeddedValue2"\n  }\n}' ]

Currently that's my only blocker for adding the streaming API to this project.

[knownasilya]

What about using https://www.npmjs.com/package/JSONStream

[juanjoDiaz]

I've looked into that one, and also into JSONparse which JSONStream uses under the hood.
The problem is that both actually caches the whole JSON in memory while processing it which totally defeats the purpose of having a streaming api imho....

[knownasilya]

Wow I didn't know that. Good catch.

[juanjoDiaz]

But no problem. I dug into the library and learn how to override it's behaviour to don't do that. You'll see. :)

[knownasilya]

Streaming api added by #235