Skip to content

Commit

Permalink
feat(make): adds generate to default targets (opendatahub-io#1176)
Browse files Browse the repository at this point in the history
Current list of default targets include `manifests` which generates
CRDs based on API code changes, but does not invoke `generate` which is
responsible for generating additional code (namely `DeepCopy` funcs).

This can result in incomplete implemetation where CRDs reflect latest
changes in the API, but internally it might not be possible to use due
to missing copy methods or even outdated implementations of those that
already exist.

This change adds it to the list of default targets so that each code
change can be committed with complete set of changes for controller-runtime.

(cherry picked from commit 4a51dfd)
  • Loading branch information
bartoszmajsak authored and zdtsw committed Aug 15, 2024
1 parent 545258e commit 190e14d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ OPERATOR_MAKE_ENV_FILE = local.mk


.PHONY: default
default: manifests lint unit-test build
default: manifests generate lint unit-test build

##@ General

Expand Down

0 comments on commit 190e14d

Please sign in to comment.