feat(make): adds generate to default targets #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current list of default targets include `manifests` which generates CRDs based on API code changes, but does not invoke `generate` which is responsible for generating additional code (namely `DeepCopy` funcs). This can result in incomplete implemetation where CRDs reflect latest changes in the API, but internally it might not be possible to use due to missing copy methods or even outdated implementations of those that already exist. This change adds it to the list of default targets so that each code change can be committed with complete set of changes for controller-runtime.
|
Alternatively we can combine both to one |
zdtsw
approved these changes
Aug 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4a51dfd
into
opendatahub-io:incubation
8 checks passed
zdtsw
pushed a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Aug 15, 2024
Current list of default targets include `manifests` which generates CRDs based on API code changes, but does not invoke `generate` which is responsible for generating additional code (namely `DeepCopy` funcs). This can result in incomplete implemetation where CRDs reflect latest changes in the API, but internally it might not be possible to use due to missing copy methods or even outdated implementations of those that already exist. This change adds it to the list of default targets so that each code change can be committed with complete set of changes for controller-runtime. (cherry picked from commit 4a51dfd)
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Aug 16, 2024
Current list of default targets include `manifests` which generates CRDs based on API code changes, but does not invoke `generate` which is responsible for generating additional code (namely `DeepCopy` funcs). This can result in incomplete implemetation where CRDs reflect latest changes in the API, but internally it might not be possible to use due to missing copy methods or even outdated implementations of those that already exist. This change adds it to the list of default targets so that each code change can be committed with complete set of changes for controller-runtime. (cherry picked from commit 4a51dfd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current list of default targets includes
manifestswhich generates CRDs based on API code changes. Still, it does not invokegeneratewhich is responsible for generating additional code (namelyDeepCopyfuncs).This can result in incomplete implementation where CRDs reflect the latest changes in the API, but internally it might not be possible to use due to missing copy methods or even outdated implementations of those that already exist.
This change adds it to the list of default targets so that each code change can be committed with the complete set of changes for
controller-runtime.How Has This Been Tested?
Screenshot or short clip
Merge criteria