fix: Fix download from gh-r

[yutkat]

Description

I tried to update plugins today (September 13, 2022) and the binary download from the GitHub release failed.
gh-r: failed to find the correct GitHub release asset to download.

It seems that the GitHub website has been updated and the method of parsing assets from HTML no longer works.
Check this command and video.
curl https://github.com/BurntSushi/ripgrep/releases
https://user-images.githubusercontent.com/8683947/189714315-fa1d28b0-755a-46f8-9239-5f16291df26b.mp4

I changed the process to get the list of released assets from the API.
This is a temporary patch and we may need to consider a few more things. However, I think it is better than not working.

Related Issue(s)

Reproduce steps

.zshrc

ZPLG_HOME="$HOME/.config/zinit"

if ! test -d "$ZPLG_HOME"; then
  mkdir -p "$ZPLG_HOME"
  chmod g-rwX "$ZPLG_HOME"
  git clone --depth 10 https://github.com/zdharma-continuum/zinit.git ${ZPLG_HOME}/bin
fi

typeset -gAH ZPLGM
ZPLGM[HOME_DIR]="${ZPLG_HOME}"
source "$ZPLG_HOME/bin/zinit.zsh"
autoload -Uz _zinit
(( ${+_comps} )) && _comps[zinit]=_zinit

zinit for \
    from'gh-r' \
    as'program' pick'ripgrep*/rg' \
  BurntSushi/ripgrep

Error

gh-r: failed to find the correct GitHub release asset to download.

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[tylerw]

I fixed this same issue locally with the following change, but your proposed fix is probably more robust:

diff --git a/zinit-install.zsh b/zinit-install.zsh
index 531f5299..f0035372 100644
--- a/zinit-install.zsh
+++ b/zinit-install.zsh
@@ -354,7 +354,7 @@ builtin source "${ZINIT[BIN_DIR]}/zinit-side.zsh" || {
 
     (
         if [[ $site = */releases ]] {
-            local url=$site/${ICE[ver]}
+            local url=$site/expanded_assets/${ICE[ver]}
 
             .zinit-get-latest-gh-r-url-part "$user" "$plugin" "$url" || return $?
 
@@ -1456,7 +1456,7 @@ builtin source "${ZINIT[BIN_DIR]}/zinit-side.zsh" || {
     local user=$1 plugin=$2 urlpart=$3
 
     if [[ -z $urlpart ]] {
-        local url=https://github.com/$user/$plugin/releases/$ICE[ver]
+        local url=https://github.com/$user/$plugin/releases/expanded_assets/$ICE[ver]
     } else {
         local url=https://$urlpart
     }

[yutkat]

@tylerw Oh! That's great. I didn't know that page existed.

Your idea looks better, so can you make a new PR instead of me?

[yutkat]

@tylerw It might not work well when ${ICE[ver]} is empty. When getting the latest version, ${ICE[ver]} will be empty.

https://github.com/BurntSushi/ripgrep/releases/expanded_assets/

[yutkat]

My current method works, but it causes a rate limit on the GitHub API, It might be better to get the latest tag somehow and fix this issue tylerw's method.

[yutkat]

I updated the patch based on tylerw's idea.

I want to make a function to get the latet tag, but I don't know where to place it properly.

[numToStr]

Also, for some of the binary, zinit is downloading incompatible binary

My machine is x86_64 but zinit is downloading arm binaries. @yutkat Does this PR also fixes this issue?

[crivotz]

@numToStr I also have the same issue as you, and I use bpick to indicate which binary I want. This PR solves the problem that the bpick could not find the indicated version.

[yutkat]

My machine is x86_64 but zinit is downloading arm binaries. @yutkat Does this PR also fixes this issue?

I haven't changed the binary determination process so that's may a different issue.

@numToStr I also have the same issue as you, and I use bpick to indicate which binary I want.

If it's fixed, why? 🤔

BTW, I'm also using x86_64 and I was able to download fd properly.

[numToStr]

BTW, I'm also using x86_64 and I was able to download fd properly

@yutkat would you mind sharing your script for fd?

[yutkat]

here
https://github.com/yutkat/dotfiles/blob/bea6bfd498e830ead373ae365d8edefec302983c/.config/zsh/rc/pluginlist.zsh#L257-L261

[crivotz]

Just for info, today I tried a fresh zinit installation and the problem with du/rg no longer occurred

[numToStr]

Yeah, I also just did zinit update everything seems to be working fine again, no errors and no downloading wrong binary.

[mrroll]

I can confirm that this PR also fixes an issue I'm having with https://github.com/starship/starship.

My arch is under the More Assets button in the latest release like so:

bpick fails to find it and errors out when installing/updating. When I have this PR checked out, it downloads the correct archive.

[yutkat]

@pschmitt @vladdoster Sorry for the mensch. But I think this is a pretty serious issue, so I hope you'll check this out as soon as possible.

[jankatins]

Can confirm, it fixes the starship problem in #374 (comment)

[vladdoster]

Big thank you to @yutkat & @tylerw for fixing!!

Sorry for delay in merging :^/.

Cheers!

[github-actions]

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀