Broaden Authorizations from SpendDescriptionV5::into_spend_description
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
commented
Oct 12, 2024
| @@ -298,12 +298,15 @@ impl SpendDescriptionV5 { | |||
| Self { cv, nullifier, rk } | |||
| } | |||
|
|
|||
| pub fn into_spend_description( | |||
| pub fn into_spend_description<A>( | |||
There was a problem hiding this comment.
This feels like it should be backwards-compatible, but I'll check with cargo semver-checks.
There was a problem hiding this comment.
#144 is not backwards-compatible, and that's the API change I actually needed, so I'm just going to deploy this at the same time.
…tion` This enables the method to be used with bundles that have spend auth signatures and proofs, but not yet binding signatures.
str4d
force-pushed
the
generalise-spend-desc-conversion
branch
from
dd0a91a to
6527e79
Compare
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the method to be used with bundles that have spend auth signatures and proofs, but not yet binding signatures.