Merge pull request #143 from zcash/generalise-spend-desc-conversion

Broaden `Authorization`s from `SpendDescriptionV5::into_spend_description`
zcash · Oct 24, 2024 · 44c4b17 · 44c4b17
2 parents 0351517 + 6527e79
commit 44c4b17
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,11 @@ and this library adheres to Rust's notion of
   `sapling_crypto::keys::EphemeralSecretKey`, matching the existing public APIs
   that expose it.
 
+### Changed
+- `sapling_crypto::bundle::SpendDescriptionV5::into_spend_description` now
+  supports any `Authorization` for which the `SpendDescription` itself is fully
+  authorized.
+
 ## [0.3.0] - 2024-10-02
 
 ### Changed

diff --git a/src/bundle.rs b/src/bundle.rs
@@ -298,12 +298,15 @@ impl SpendDescriptionV5 {
         Self { cv, nullifier, rk }
     }
 
-    pub fn into_spend_description(
+    pub fn into_spend_description<A>(
         self,
         anchor: bls12_381::Scalar,
         zkproof: GrothProofBytes,
         spend_auth_sig: redjubjub::Signature<SpendAuth>,
-    ) -> SpendDescription<Authorized> {
+    ) -> SpendDescription<A>
+    where
+        A: Authorization<SpendProof = GrothProofBytes, AuthSig = redjubjub::Signature<SpendAuth>>,
+    {
         SpendDescription {
             cv: self.cv,
             anchor,