Implement Serde for fields and curves #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
reviewed
Sep 7, 2022
src/serde_impl.rs
Outdated
| test_roundtrip(&f); | ||
| assert_eq!( | ||
| serde_json::from_slice::<EpAffine>( | ||
| b"[0,0,0,0,237,48,45,153,27,249,76,9,252,152,70,34,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,64]" |
There was a problem hiding this comment.
I have not checked this value (or the one for EqAffine::generator() below).
daira
approved these changes
Sep 7, 2022
This was referenced Sep 7, 2022
Closed
daira
reviewed
Sep 7, 2022
daira
reviewed
Sep 7, 2022
Codecov ReportBase: 66.15% // Head: 72.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 66.15% 72.35% +6.20%
==========================================
Files 12 13 +1
Lines 1427 1530 +103
==========================================
+ Hits 944 1107 +163
+ Misses 483 423 -60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@vmx Would you also consider adding borsh support or is that out of scope? |
|
@parazyd I won't have time working on borsh support. |
|
@vmx Alright, I will then add it after this PR is merged. Thank you. |
arthurgreef
reviewed
Sep 11, 2022
|
Is this going to be merged in? |
str4d
requested changes
Oct 13, 2022
|
This PR needs to be rebased (GitHub's UI indicates there is a merge conflict). |
Currently Serde is only implemented for `Fp`, `Fq`, `EpAffine` and `EqAffine`. Support can be enabled with the `serde` feature.
|
As I needed to rebase, I did merged all commits into a single one. It should now include all the things mentioned in the review. Notable things are:
|
str4d
requested changes
Oct 15, 2022
|
Following this model, I have also implemented Serde for the |
This was referenced Nov 16, 2022
vmx
pushed a commit
to ipld/libipld
that referenced
this pull request
Nov 17, 2022
Currently, the Serializer sets `is_human_readable` to false, but the Deserializer implicitly sets it to true. This causes issues when other types try to use serde based on this value, as in zcash/pasta_curves#48, so this PR makes them consistently false. BREAKING CHANGE: the Serde deserializer is now defined as non human readable
vmx
added a commit
to filecoin-project/fil_pasta_curves
that referenced
this pull request
Nov 17, 2022
Implement serde for fields and curves. Those changes are based on zcash#48 and will eventually also land upstream.
str4d
approved these changes
Nov 19, 2022
tyshko5
pushed a commit
to tyshko5/libipld
that referenced
this pull request
Nov 29, 2022
fix: make the deserializer human-unreadable (ipld#165) Currently, the Serializer sets `is_human_readable` to false, but the Deserializer implicitly sets it to true. This causes issues when other types try to use serde based on this value, as in zcash/pasta_curves#48, so this PR makes them consistently false. BREAKING CHANGE: the Serde deserializer is now defined as non human readable lint fix try fix CI empty revert try fix 2 fix ci 2 fix ci 3 less branches no dep:, arb feature fix arb lint fixes fix wasm ci fix arb 3 fix wasm ci fix wasm ci 2 fix no_std build requested changes getrandom optional remove getrandom fix recursion requested changes shrink fix duplicate code update `multihash` in other crates fix (cargo-release) version 0.15.0 (cargo-release) version 0.15.0 (cargo-release) version 0.15.0 (cargo-release) version 0.15.0 (cargo-release) version 0.15.0 (cargo-release) version 0.15.0 (cargo-release) version 0.15.0 fixes minor remove custom generator remove arbitrary_ipld_vec/map fn_s remove filtering of fleat nans make arbitrary_ipld private copy size to avoid too small lists/maps fix arbitrary_size with actual size fix size == 0 edgecase fmt && clippy cliipy chore: fix Android build on CI (ipld#169) Also cache `cargo-apk` for faster CI run times. move everything to arb module fmt
vmx
pushed a commit
to ipld/rust-ipld-core
that referenced
this pull request
Feb 22, 2024
Currently, the Serializer sets `is_human_readable` to false, but the Deserializer implicitly sets it to true. This causes issues when other types try to use serde based on this value, as in zcash/pasta_curves#48, so this PR makes them consistently false. BREAKING CHANGE: the Serde deserializer is now defined as non human readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Serde is only implemented for
Fp,Fq,EpAffineandEqAffine.Support can be enabled with the
serdefeature.It's based on the implementation in
blstrs: https://github.com/filecoin-project/blstrs/blob/master/src/serde_impl.rsPlease let me know if that's the correct approach, or e.g. you'd like to serialize them to four
u64s.I've only implemented it for the things I currently need, but I'm happy to provide an implementation for all curves.