Serde for Affine points #43
Conversation
arthurgreef
force-pushed
the
arthurgr/serde
branch
from
fddbb36
to
37dedf2
Compare
|
Hi there. Any change of a review soon? Thanks. |
|
Hi - can someone take a look? Thanks. |
| @@ -20,6 +20,7 @@ all-features = true | |||
| rustdoc-args = ["--cfg", "docsrs", "--html-in-header", "katex-header.html"] | |||
|
|
|||
| [dev-dependencies] | |||
| bincode = "1.2.1" | |||
There was a problem hiding this comment.
https://crates.io/crates/bincode
Bincode attempts to protect against hostile data. There is a maximum size configuration available (
bincode::config::Bounded), but not enabled in the default configuration. Enabling it causes pre-allocation size to be limited to prevent against memory exhaustion attacks.
We should probably enable bincode::config::Bounded.
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 66.15% 70.60% +4.45%
==========================================
Files 12 12
Lines 1427 1456 +29
==========================================
+ Hits 944 1028 +84
+ Misses 483 428 -55
Continue to review full report at Codecov.
|
arthurgreef
force-pushed
the
arthurgr/serde
branch
from
37dedf2
to
a41992e
Compare
|
Thanks for the review @daira. I was not sure if my change is what you were looking for. Bincode is a dev dependency so that implementors can choose how they would like to serde. I added bincode options to the test. |
|
Hey @daira, any chance you could take another look? Thanks. |
|
This and #48 appear to conflict. |
|
Closing in favour of #48. |
No description provided.