Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rand crate dependency to 0.7 #91

Merged
merged 15 commits into from
Jul 26, 2019
Merged

Upgrade rand crate dependency to 0.7 #91

merged 15 commits into from
Jul 26, 2019

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jul 14, 2019

Also moves to rand_core where possible, to reduce the dependency surface.

Closes #60.

@str4d str4d requested a review from ebfull July 14, 2019 11:30
@str4d
Copy link
Contributor Author

str4d commented Jul 14, 2019

This PR is best reviewed by-commit. I migrated via intermediate rand versions to reduce the size of the incremental changes.

@str4d str4d force-pushed the upgrade-rand branch 2 times, most recently from 79c66d2 to eecef7d Compare July 16, 2019 07:21
daira
daira approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. A couple of minor comment suggestions.

sapling-crypto/src/jubjub/fs.rs Outdated Show resolved Hide resolved
ff/ff_derive/src/lib.rs Outdated Show resolved Hide resolved
ebfull
ebfull approved these changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@ebfull ebfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incredible PR, well done.

@str4d str4d merged commit 05f098e into zcash:master Jul 26, 2019
@str4d str4d deleted the upgrade-rand branch July 26, 2019 22:31
@str4d str4d mentioned this pull request Jul 26, 2019
Merged
This was referenced Aug 5, 2019
Closed
Closed
@str4d str4d added this to the v0.1.0 milestone Aug 22, 2019
@str4d str4d mentioned this pull request Sep 26, 2019
Merged
str4d added a commit to str4d/librustzcash that referenced this pull request Oct 8, 2019
@str4d
Fix pairing benchmarks
b872e9f 
They were broken by zcash#91 but went unnoticed because CI does not compile
the benchmarks, which requires the nightly toolchain.
ebfull pushed a commit to ebfull/librustzcash that referenced this pull request Mar 4, 2020
@str4d
Fix pairing benchmarks
0de7279 
They were broken by zcash#91 but went unnoticed because CI does not compile
the benchmarks, which requires the nightly toolchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebfull ebfull ebfull approved these changes

@daira daira daira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Upgrade rand crate to 0.6
3 participants
@str4d @daira @ebfull